8000 feat: add copy button for workspace name in breadcrumb by matifali · Pull Request #17822 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

feat: add copy button for workspace name in breadcrumb #17822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

Conversation

matifali
Copy link
Member
@matifali matifali commented May 14, 2025

Closes #17820

Demo

Screen.Recording.2025-05-14.at.08.37.42.mov

@matifali matifali self-assigned this May 14, 2025
@matifali matifali force-pushed the atif/issue-17829 branch from 68e70a9 to 605ac9b Compare May 14, 2025 08:15
@BrunoQuaresma BrunoQuaresma self-assigned this May 14, 2025
@BrunoQuaresma BrunoQuaresma requested review from a team, BrunoQuaresma and jaaydenh and removed request for BrunoQuaresma and a team May 14, 2025 12:04
@Emyrk
Copy link
Member
Emyrk commented May 15, 2025

Is this a storybook thing, or has the spacing really changed on the nav bar here?
The new code looks to have a bit more spacing.

Screenshot From 2025-05-15 11-53-31

https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=68248278c9d187b52c4ff47f

@BrunoQuaresma
Copy link
Collaborator

@Emyrk it changed, but it still looking good 👍

Copy link
Member
@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly reviewed via chromatic storybook changes 😄

@matifali matifali merged commit 2c49fd9 into main May 15, 2025
29 checks passed
@matifali matifali deleted the atif/issue-17829 branch May 15, 2025 17:41
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Copy Button to the Workspace Name
3 participants
0