8000 fix: enrich the `notLoggedInMessage` error message with the full path to the coder by cstyan · Pull Request #17715 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: enrich the notLoggedInMessage error message with the full path to the coder #17715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025
Merged

fix: enrich the notLoggedInMessage error message with the full path to the coder #17715

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
730b5dd
enrich the "not logged in" error message with the full path to the coder
cstyan May 7, 2025
d3d5e1e
update tests that were failing due to login error message changes
cstyan May 8, 2025
364c8bf
fix lint error; move os.Executable call outside of the anonymous
cstyan May 8, 2025
b561db4
change require back to assert, not sure why I changed this before
cstyan May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint error; move os.Executable call outside of the anonymous 
goroutine

Signed-off-by: Callum Styan <callumstyan@gmail.com>
  • Loading branch information
@cstyan
cstyan committed May 8, 2025
commit 364c8bfbed1e6959e92e201b469133ac748fa223
8 changes: 4 additions & 4 deletions cli/logout_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@
logout.Stdin = pty.Input()
logout.Stdout = pty.Output()

go func() {
executable, err := os.Executable()
require.NoError(t, err)
require.NotEqual(t, "", executable)
executable, err := os.Executable()
require.NoError(t, err)
require.NotEqual(t, "", executable)

go func() {
defer close(logoutChan)
err = logout.Run()
require.Contains(t, err.Error(), fmt.Sprintf("Try logging in using '%s login <url>'.", executable))

Check failure on line 100 in cli/logout_test.go

View workflow job for this annotation

GitHub Actions / lint 

ruleguard: Do not call functions that may call t.FailNow in a goroutine, as this can cause data races (see testing.go:834) (gocritic)
}()

<-logoutChan
Expand Down
Loading
0