10000 fix: fix for prebuilds claiming and deletion by evgeniy-scherbina · Pull Request #17624 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: fix for prebuilds claiming and deletion #17624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 1, 2025
Merged

fix: fix for prebuilds claiming and deletion #17624

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5704765
fix: fix for prebuilds claiming and deletion
evgeniy-scherbina Apr 30, 2025
1f39024
test: add unit-test for claiming & immutable params scenario
evgeniy-scherbina Apr 30, 2025
dd1ab45
test: add unit-test for deletion & immutable params scenario
evgeniy-scherbina Apr 30, 2025
77708ed
test: add small comment
evgeniy-scherbina Apr 30, 2025
e04ae44
fix: ensure resolver evaluates previous & new values to determine mut…
dannykopping May 1, 2025
abc59ec
Merge branch 'main' of github.com:/coder/coder into yevhenii/prebuild…
dannykopping May 1, 2025
d62589e
chore: restore unnecessarily removed code
dannykopping May 1, 2025
21bb481
make fmt
dannykopping May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: fix for prebuilds claiming and deletion
  • Loading branch information
@evgeniy-scherbina
evgeniy-scherbina committed Apr 30, 2025
commit 57047656ec48bce34a59d5edee84dc5bb66ea80b
5 changes: 5 additions & 0 deletions coderd/wsbuilder/wsbuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,11 @@ func (b *Builder) findNewBuildParameterValue(name string) *codersdk.WorkspaceBui
}

func (b *Builder) getLastBuildParameters() ([]database.WorkspaceBuildParameter, error) {
// TODO: exclude preset params from this list instead of returning nothing?
if b.prebuildClaimedBy != uuid.Nil || b.prebuild {
return nil, nil
}

if b.lastBuildParameters != nil {
return *b.lastBuildParameters, nil
}
Expand Down
Loading
0