8000 chore: replace MoreMenu with DropdownMenu by jaaydenh · Pull Request #17615 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: replace MoreMenu with DropdownMenu #17615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 1, 2025
Merged

chore: replace MoreMenu with DropdownMenu #17615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bff8357
chore: refactor more menu
jaaydenh Feb 17, 2025
e825cf0
chore: update EllipsisVertical icon size
jaaydenh Apr 30, 2025
732006a
chore: cleanup
jaaydenh Apr 30, 2025
47f4839
chore: cleanup
jaaydenh Apr 30, 2025
826874b
fix: cleanup
jaaydenh Apr 30, 2025
6d2dbe8
fix: cleanup
jaaydenh Apr 30, 2025
d337372
fix: fix UsersPage storybook tests
jaaydenh Apr 30, 2025
e13f224
fix: fix test
jaaydenh Apr 30, 2025
bb25e43
fix: update tests
jaaydenh Apr 30, 2025
d56d988
fix: fix tests
jaaydenh Apr 30, 2025
d795480
fix: removed unused imports
jaaydenh Apr 30, 2025
43afbe4
chore: remove unused dependency
jaaydenh Apr 30, 2025
9b7a2e0
fix: fix e2e tests
jaaydenh May 1, 2025
82b9b09
chore: update to use DropdownMenu
jaaydenh May 1, 2025
fe820b3
8000 chore: update MoreMenu to use DropdownMenu
jaaydenh May 1, 2025
fac467a
chore: delete MoreMenu
jaaydenh May 1, 2025
c57d54a
fix: fix merge
jaaydenh May 1, 2025
564fedb
fix: fix merge
jaaydenh May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update EllipsisVertical icon size
  • Loading branch information
@jaaydenh
jaaydenh committed May 1, 2025
commit e825cf0f46a2a1271b913e34f5cd812d0e11c9ce
8 changes: 6 additions & 2 deletions site/src/pages/GroupsPage/GroupPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,12 @@ const GroupMemberRow: FC<GroupMemberRowProps> = ({
{canUpdate && (
<DropdownMenu>
<DropdownMenuTrigger asChild>
<ShadcnButton size="icon" variant="subtle" aria-label="Open menu">
<EllipsisVertical className="size-icon-md" aria-hidden="true" />
<ShadcnButton
size="icon-lg"
variant="subtle"
aria-label="Open menu"
>
<EllipsisVertical aria-hidden="true" />
<span className="sr-only">Open menu</span>
</ShadcnButton>
</DropdownMenuTrigger>
Expand Down
8 changes: 6 additions & 2 deletions site/src/pages/OrganizationSettingsPage/CustomRolesPage/CustomRolesPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,12 @@ const RoleRow: FC<RoleRowProps> = ({
{!role.built_in && (canUpdateOrgRole || canDeleteOrgRole) && (
<DropdownMenu>
<DropdownMenuTrigger asChild>
<ShadcnButton size="icon" variant="subtle" aria-label="Open menu">
<EllipsisVertical className="size-icon-md" aria-hidden="true" />
<ShadcnButton
size="icon-lg"
variant="subtle"
aria-label="Open menu"
>
<EllipsisVertical aria-hidden="true" />
<span className="sr-only">Open menu</span>
</ShadcnButton>
</DropdownMenuTrigger>
Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/OrganizationSettingsPage/IdpSyncPage/IdpGroupSyncForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ const GroupRow: FC<GroupRowProps> = ({
aria-label="delete"
onClick={() => onDelete(idpGroup)}
>
<Trash className="size-icon-sm" />
<Trash />
<span className="sr-only">Delete IdP mapping</span>
</Button>
</TableCell>
Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/OrganizationSettingsPage/IdpSyncPage/IdpRoleSyncForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ const RoleRow: FC<RoleRowProps> = ({
aria-label="delete"
onClick={() => onDelete(idpRole)}
>
<Trash className="size-icon-sm" />
<Trash />
<span className="sr-only">Delete IdP mapping</span>
</Button>
</TableCell>
Expand Down
25 changes: 11 additions & 14 deletions site/src/pages/OrganizationSettingsPage/OrganizationMembersPageView.tsx
View file
Open in desktop
E30A
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@ import type {
import { ErrorAlert } from "components/Alert/ErrorAlert";
import { Avatar } from "components/Avatar/Avatar";
import { AvatarData } from "components/Avatar/AvatarData";
import { displayError, displaySuccess } from "components/GlobalSnackbar/utils";
import { Loader } from "components/Loader/Loader";
import { PaginationContainer } from "components/PaginationWidget/PaginationContainer";
import {
SettingsHeader,
SettingsHeaderTitle,
} from "components/SettingsHeader/SettingsHeader";
import { Button } from "components/Button/Button";
import {
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuTrigger,
} from "components/DropdownMenu/DropdownMenu";
import { displayError, displaySuccess } from "components/GlobalSnackbar/utils";
import { Loader } from "components/Loader/Loader";
import { PaginationContainer } from "components/PaginationWidget/PaginationContainer";
import {
SettingsHeader,
SettingsHeaderTitle,
} from "components/SettingsHeader/SettingsHeader";
import { Stack } from "components/Stack/Stack";
import {
Table,
Expand All @@ -35,7 +35,7 @@ import {
} from "components/Table/Table";
import { UserAutocomplete } from "components/UserAutocomplete/UserAutocomplete";
import type { PaginationResultInfo } from "hooks/usePaginatedQuery";
import { TriangleAlert, EllipsisVertical } from "lucide-react";
import { EllipsisVertical, TriangleAlert } from "lucide-react";
import { UserGroupsCell } from "pages/UsersPage/UsersTable/UserGroupsCell";
import { type FC, useState } from "react";
import { TableColumnHelpTooltip } from "./UserTable/TableColumnHelpTooltip";
Expand Down Expand Up @@ -166,14 +166,11 @@ export const OrganizationMembersPageView: FC<
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
size="icon"
size="icon-lg"
variant="subtle"
aria-label="Open menu"
>
<EllipsisVertical
className="size-icon-md"
aria-hidden="true"
/>
<EllipsisVertical aria-hidden="true" />
<span className="sr-only">Open menu</span>
</Button>
</DropdownMenuTrigger>
Expand All @@ -187,7 +184,7 @@ export const OrganizationMembersPageView: FC<
</DropdownMenuContent>
</DropdownMenu>
)}
</TableCell>
</TableCell>
</TableRow>
))
) : (
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/TemplatePage/TemplatePageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ const TemplateMenu: FC<TemplateMenuProps> = ({
<>
<DropdownMenu>
<DropdownMenuTrigger asChild>
<ShadcnButton size="icon" variant="subtle" aria-label="Open menu">
<EllipsisVertical className="size-icon-md" aria-hidden="true" />
<ShadcnButton size="icon-lg" variant="subtle" aria-label="Open menu">
<EllipsisVertical aria-hidden="true" />
<span className="sr-only">Open menu</span>
</ShadcnButton>
</DropdownMenuTrigger>
Expand Down
14 changes: 4 additions & 10 deletions site/src/pages/TemplateSettingsPage/TemplatePermissionsPage/TemplatePermissionsPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,14 +293,11 @@ export const TemplatePermissionsPageView: FC<
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
size="icon"
size="icon-lg"
variant="subtle"
aria-label="Open menu"
>
<EllipsisVertical
className="size-icon-md"
aria-hidden="true"
/>
<EllipsisVertical aria-hidden="true" />
<span className="sr-only">Open menu</span>
</Button>
</DropdownMenuTrigger>
Expand Down Expand Up @@ -352,14 +349,11 @@ export const TemplatePermissionsPageView: FC<
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
size="icon"
size="icon-lg"
variant="subtle"
aria-label="Open menu"
>
<EllipsisVertical
className="size-icon-md"
aria-hidden="true"
/>
<EllipsisVertical aria-hidden="true" />
<span className="sr-only">Open menu</span>
</Button>
</DropdownMenuTrigger>
Expand Down
11 changes: 6 additions & 5 deletions site/src/pages/UsersPage/UsersTable/UsersTableBody.tsx
View file
Open in desktop
< B13F td class="blob-code blob-code-context js-file-line"> </Button>
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,12 @@ export const UsersTableBody: FC<UsersTableBodyProps> = ({
<TableCell>
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button size="icon" variant="subtle" aria-label="Open menu">
<EllipsisVertical
className="size-icon-md"
aria-hidden="true"
/>
<Button
size="icon-lg"
variant="subtle"
aria-label="Open menu"
>
<EllipsisVertical aria-hidden="true" />
<span className="sr-only">Open menu</span>
</DropdownMenuTrigger>
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,14 @@ export const WorkspaceActions: FC<WorkspaceActionsProps> = ({
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
size="icon"
size="icon-lg"
variant="subtle"
aria-label="More options"
data-testid="workspace-options-button"
aria-controls="workspace-options"
disabled={!canAcceptJobs}
>
<EllipsisVertical className="size-icon-md" aria-hidden="true" />
<EllipsisVertical aria-hidden="true" />
<span className="sr-only">More options</span>
</Button>
</DropdownMenuTrigger>
Expand Down
0