feat: bypass built-in CORS handling for workspace apps #17596
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
🚀 Deploying PR 17596 ... |
|
Sorry for the github noise. This is not done, it is still relevant, I just don't have the time to take this over the line. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #15669
This PR introduces a partial fix for #15096; it allows operators to specify the CORS behavior on a per-
coder_applevel.This change requires
cors_behaviorto be set on a givencoder_app; coder/terraform-provider-coder#309 introduces that new attribute.coderdcurrently handles CORS automatically by handling preflight requests and stripping CORS headers from upstreamcoder_appresponses.Two CORS behaviors are defined in this PR:
simple: the current behavior of handling CORS withincoderdpassthru: new behavior which transparently bypasses our CORS handling incoderdso thecoder_appservice is then fully responsible for handling CORSWe plan to further add this behavior to port shares.
The sharing level (
owner,authenticated,public) is still respected, regardless of CORS behavior.