8000 fix: display validation error for workspace name by jaaydenh · Pull Request #17564 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: display validation error for workspace name #17564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

fix: display validation error for workspace name #17564

merged 3 commits into from
Apr 30, 2025

Conversation

jaaydenh
Copy link
Contributor
  • Display form validation error for workspace name
  • Scroll to the workspace name field if there is a validation error

@jaaydenh jaaydenh self-assigned this Apr 24, 2025
jaaydenh
jaaydenh commented Apr 24, 2025
View reviewed changes
site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
@@ -477,7 +488,6 @@ export const CreateWorkspacePageViewExperimental: FC<

return (
<DynamicParameter
{...getFieldHelpers(parameterInputName)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are not using the MUI TextField, this is not necessary

@jaaydenh jaaydenh requested a review from aslilac April 24, 2025 17:45
aslilac
aslilac requested changes Apr 24, 2025
View reviewed changes
Copy link
Member
@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to use a ref here

8000
@jaaydenh
Copy link
Contributor Author

@aslilac updated for useRef

@jaaydenh jaaydenh requested a review from aslilac April 30, 2025 11:49
@jaaydenh jaaydenh force-pushed the jaaydenh/workspace-name-validation branch from bb92ca8 to dd76a3a Compare April 30, 2025 16:02
@jaaydenh jaaydenh merged commit d104cd6 into main Apr 30, 2025
29 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/workspace-name-validation branch April 30, 2025 20:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

Assignees

@jaaydenh jaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaaydenh @aslilac
0