8000 feat: setup connection to dynamic parameters websocket by jaaydenh · Pull Request #17393 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

feat: setup connection to dynamic parameters websocket #17393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 16, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: display websocket error in UI
  • Loading branch information
jaaydenh committed Apr 16, 2025
commit 9a9201e919c4e6f41a055cebd5c04a7cecaaf54e
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { autoCreateWorkspace, createWorkspace } from "api/queries/workspaces";
import type {
DynamicParametersRequest,
DynamicParametersResponse,
Template,
Workspace,
} from "api/typesGenerated";
import { Loader } from "components/Loader/Loader";
Expand Down Expand Up @@ -50,6 +49,7 @@ const CreateWorkspacePageExperimental: FC = () => {
useState<DynamicParametersResponse | null>(null);
const [wsResponseId, setWSResponseId] = useState<number>(-1);
const ws = useRef<WebSocket | null>(null);
const [wsError, setWsError] = useState<Error | null>(null);

const customVersionId = searchParams.get("version") ?? undefined;
const defaultName = searchParams.get("name");
Expand Down Expand Up @@ -103,10 +103,7 @@ const CreateW 9388 orkspacePageExperimental: FC = () => {
const socket = API.templateVersionDynamicParameters(realizedVersionId, {
onMessage,
onError: (error) => {
console.error(
"Failed to parse dynamic parameters webSocket message:",
error,
);
setWsError(error);
},
});

Expand Down Expand Up @@ -244,11 +241,12 @@ const CreateWorkspacePageExperimental: FC = () => {
<CreateWorkspacePageViewExperimental
mode={mode}
defaultName={defaultName}
diagnostics={currentResponse.diagnostics}
diagnostics={currentResponse?.diagnostics ?? []}
disabledParams={disabledParams}
defaultOwner={me}
autofillParameters={autofillParameters}
error={
wsError ||
createWorkspaceMutation.error ||
autoCreateError ||
loadFormDataError ||
Expand Down
Loading
0