8000 chore: fill out workspace owner data for dynamic parameters by aslilac · Pull Request #17366 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: fill out workspace owner data for dynamic parameters #17366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 17, 2025
Merged

chore: fill out workspace owner data for dynamic parameters #17366

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
074e0bb
chore: update testutil chan helpers
aslilac Apr 15, 2025
3a403c1
whooooops
aslilac Apr 15, 2025
35ac954
like this right?
aslilac Apr 15, 2025
1820c3d
Update parameters_test.go
aslilac Apr 15, 2025
52373b7
Merge branch 'main' into lilac/parameters-owner
aslilac Apr 16, 2025
2b4c609
Merge branch 'main' into lilac/parameters-owner
aslilac Apr 17, 2025
8208b7d
🪦
aslilac Apr 17, 2025
aba1d09
fix tests
aslilac Apr 17, 2025
27a01c9
🧹
aslilac Apr 17, 2025
e9d235d
strings tho
aslilac Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@aslilac
aslilac committed Apr 17, 2025
commit aba1d0978c0d8e8942661d5604037851f4017b74
6 changes: 5 additions & 1 deletion coderd/parameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,11 @@ func (api *API) getWorkspaceOwnerData(

var ownerRoles []previewtypes.WorkspaceOwnerRBACRole
g.Go(func() error {
row, err := api.Database.GetAuthorizationUserRoles(ctx, user.ID)
// nolint:gocritic // This is kind of the wrong query to use here, but it
// matches how the provisioner currently works. We should figure out
// something that needs less escalation but has the correct behavior.
sysCtx := dbauthz.AsSystemRestricted(ctx)
row, err := api.Database.GetAuthorizationUserRoles(sysCtx, user.ID)
if err != nil {
return err
}
Expand Down
Loading
0