8000 feat: run a terraform plan before creating workspaces with the given template parameters by deansheather · Pull Request #1732 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: run a terraform plan before creating workspaces with the given template parameters #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 1, 2022
Merged

feat: run a terraform plan before creating workspaces with the given template parameters #1732

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3e9ecc3
feat: add new provisioner job type template_version_plan
deansheather May 25, 2022
cf033aa
feat: finish implementing workspace planning
deansheather May 27, 2022
bafe1c1
merge main
deansheather May 27, 2022
cfe34af
big tests
deansheather May 27, 2022
0d03a39
fix: workspaces: relax error assertion
johnstcn May 27, 2022
4078fd1
fix
deansheather May 27, 2022
8d04749
fixup! fix
deansheather May 27, 2022
4b06c72
gen
deansheather May 27, 2022
2fee23a
fixup! gen
deansheather May 27, 2022
6b95e54
remove heavy object nesting in tests
deansheather May 27, 2022
0b6d083
Rename template version plan to template version dry run
deansheather May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: workspaces: relax error assertion
  • Loading branch information
@johnstcn
johnstcn committed May 27, 2022
commit 0d03a396a5e0a22205ae69277c5a750703728c39
2 changes: 1 addition & 1 deletion coderd/workspaces_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ func TestWorkspaceUpdateAutostart(t *testing.T) {
})

if testCase.expectedError != "" {
require.EqualError(t, err, testCase.expectedError, "unexpected error when setting workspace autostart schedule")
require.ErrorContains(t, err, testCase.expectedError, "unexpected error when setting workspace autostart schedule")
return
}

Expand Down
0