8000 docs: add docs preview GitHub action by EdwardAngert · Pull Request #17317 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

docs: add docs preview GitHub action #17317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

EdwardAngert
Copy link
Contributor
@EdwardAngert EdwardAngert commented Apr 9, 2025

Summary

This PR adds a simplified docs preview GitHub action that comments on PRs with Vercel preview links when documentation changes. It improves upon the more complex implementation in PR #17282 by:

  • Focusing on the core functionality of providing Vercel preview links
  • Using established GitHub Actions like tj-actions/changed-files
  • Implementing proper security practices without overcomplication
  • Highlighting newly added documentation referenced in manifest.json

The action will:

  1. Detect when documentation files change in a PR
  2. Generate Vercel preview links for changed documents
  3. Create (or update) a PR comment with links to previews
  4. Highlight newly added documentation when manifest.json changes

Future iterations will:

  • Consolidate shared actions in a workflow that runs first

Test plan

  • Create a PR that modifies docs files
  • Verify the action runs and comments on the PR with preview links
  • Modify manifest.json to add a new doc and verify it's highlighted in the comment

🤖 Generated with Claude Code

Creates a simplified docs preview action that comments on PRs with Vercel preview links.
The action shows changed files and highlights newly added documentation from manifest.json.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@EdwardAngert EdwardAngert changed the title Add simplified docs preview GitHub action docs: add docs preview GitHub action Apr 9, 2025
EdwardAngert and others added 4 commits April 9, 2025 14:33
…o use the same SHA and version (v45.0.7) that the docs-ci.yaml workflow uses.\n\n\ud83e\udd16 Generated with [Claude Code](https://claude.ai/code)\n\nCo-Authored-By: Claude <noreply@anthropic.com>\
…d to match patterns from the successful pr-deploy.yaml workflow:\n- Added job-level pull-requests write permission\n- Added explicit env var for PR_NUMBER\n- Added explicit GITHUB_TOKEN environment variable\n- Added reactions-edit-mode for consistency\n\n\ud83e\udd16 Generated with [Claude Code](https://claude.ai/code)\n\nCo-Authored-By: Claude <noreply@anthropic.com>\
@EdwardAngert
Copy link
Contributor Author

testing against this PR in #17319

2025-04-09_15-56-17

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to reuse this action anywhere else? If not I would move it to the main workflow file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR's just to get it started - we've got another PR with workflow improvements in #17322

@EdwardAngert EdwardAngert requested a review from matifali April 10, 2025 15:11
@matifali matifali removed their request for review April 16, 2025 07:40
@EdwardAngert EdwardAngert marked this pull request as draft April 22, 2025 18:00
EdwardAngert added a commit that referenced this pull request Apr 23, 2025
Combines features from PRs #17317, #17322, and #17370:
- Adds Vale style checking for documentation
- Creates a reusable workflow for documentation validation
- Optimizes PR checks and post-merge validation
- Adds automatic GitHub issue creation for broken links
- Updates all documentation checks to run in a structured manner

This PR supersedes:
- PR #17317: Docs Preview GitHub Action
- PR #17322: Shared Docs GitHub Action
- PR #17370: Vale Style Checking and Docs Workflow Improvements
@EdwardAngert
Copy link
Contributor Author

replaced by #17522

@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs/site docs site-related issue/task/feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0