8000 fix: prevent invalid render output for build logs by Parkreiner · Pull Request #17233 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: prevent invalid render output for build logs #17233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
Merged

fix: prevent invalid render output for build logs #17233

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f221f
fix: prevent invalid render input for build logs
Parkreiner Apr 2, 2025
8eabe48
refactor: switch IDs back to numbers
Parkreiner Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: switch IDs back to numbers
  • Loading branch information
@Parkreiner
Parkreiner committed Apr 2, 2025
commit 8eabe48f98ee86886a0a26005cb2a9ccf4c0c14f
2 changes: 1 addition & 1 deletion site/src/components/Logs/LogLine.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { MONOSPACE_FONT_FAMILY } from "theme/constants";
export const DEFAULT_LOG_LINE_SIDE_PADDING = 24;

export interface Line {
id: string;
id: number;
time: string;
output: string;
level: LogLevel;
Expand Down
2 changes: 1 addition & 1 deletion site/src/components/Logs/Logs.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const meta: Meta<typeof Logs> = {
component: Logs,
args: {
lines: MockWorkspaceBuildLogs.map<Line>((log) => ({
id: String(log.id),
id: log.id,
level: log.log_level,
time: log.created_at,
output: log.output,
Expand Down
Loading
Loading
0