chore: add files cache for reading template tar archives from db #17141
Conversation
bad07d5 to
3c6b6ed
Compare
5cf9b25 to
125ef95
Compare
what would it look like if the entry got evicted while someone was holding it? the gc wouldn't actually free it, but then if someone requests it again we'd end up with a separate copy of everything because the cache would no longer see it. I kinda feel like an expiration time would only mask bugs. |
You are right. Can we add an issue to throw some prometheus metrics around this then? So if something does happen, we have somewhere to look. |
Closes #17052
Requirements
Multiple template versions can share a single "file"
fs.FSinterface pointers.Files should be "ref counted" so that they're released when no one is using them.
You should be able to fetch multiple different files in parallel, but you should not fetch the same file multiple times in parallel.
sync.Mutexand alazy.ValueWithErrorper file ID.Implementation
Uses afero for turning the tar data from the database into a readonly
io/fs.FSAdds a
lazy.ValueWithErroras a counterpart tolazy.Value, but with the ability to fail