8000 chore: add db queries for dynamic parameters by aslilac · Pull Request #17137 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: add db queries for dynamic parameters #17137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2025
Merged

chore: add db queries for dynamic parameters #17137

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5b542a
chore: add db queries for dynamic parameters
aslilac Mar 27, 2025
72b37be
clean up permissions check
aslilac Apr 1, 2025
89f091c
add comment
aslilac Apr 1, 2025
00526ef
oops
aslilac Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up permissions check
  • Loading branch information
@aslilac
aslilac committed Apr 1, 2025
commit 72b37be217fba0a20a6b1fa7b4a9d00242999bce
21 changes: 5 additions & 16 deletions coderd/database/dbauthz/dbauthz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2459,23 +2459,12 @@ func (q *querier) GetTemplateVersionParameters(ctx context.Context, templateVers
}

func (q *querier) GetTemplateVersionTerraformValues(ctx context.Context, templateVersionID uuid.UUID) (database.TemplateVersionTerraformValue, error) {
tv, err := q.db.GetTemplateVersionByID(ctx, templateVersionID)
if err != nil {
return database.TemplateVersionTerraformValue{}, err
}

var object rbac.Objecter
template, err := q.db.GetTemplateByID(ctx, tv.TemplateID.UUID)
// The template_version_terraform_values table should follow the same access
// control as the template_version table. Rather than reimplement the checks,
// we just defer to existing implementation. (plus we'd need to use this query
// to reimplement the proper checks anyway)
_, err := q.GetTemplateVersionByID(ctx, templateVersionID)
if err != nil {
if !errors.Is(err, sql.ErrNoRows) {
return database.TemplateVersionTerraformValue{}, err
}
object = rbac.ResourceTemplate.InOrg(tv.OrganizationID)
} else {
object = tv.RBACObject(template)
}

if err := q.authorizeContext(ctx, policy.ActionRead, object); err != nil {
return database.TemplateVersionTerraformValue{}, err
}
return q.db.GetTemplateVersionTerraformValues(ctx, templateVersionID)
Expand Down
0