10000 chore: persist template import terraform plan in postgres by aslilac · Pull Request #17012 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

chore: persist template import terraform plan in postgres #17012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 24, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
and do the insert again
  • Loading branch information
aslilac committed Mar 20, 2025
commit a46470eb80b3eae546b6168a64f3bf90c47c16a8
16 changes: 8 additions & 8 deletions coderd/provisionerdserver/provisionerdserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -1413,14 +1413,14 @@ func (s *server) CompleteJob(ctx context.Context, completed *proto.CompletedJob)
return nil, xerrors.Errorf("update template version external auth providers: %w", err)
}

// err = s.Database.InsertTemplateVersionTerraformValuesByJobID(ctx, database.insertTemplateVersionTerraformValuesByJobIDParams{
// JobID: jobID,
// CachedPlan: jobType.TemplateImport.Plan,
// UpdatedAt: s.timeNow(),
// })
// if err != nil {
// return nil, xerrors.Errorf("insert template version terraform data: %w", err)
// }
err = s.Database.InsertTemplateVersionTerraformValuesByJobID(ctx, database.InsertTemplateVersionTerraformValuesByJobIDParams{
JobID: jobID,
CachedPlan: jobType.TemplateImport.Plan,
UpdatedAt: s.timeNow(),
})
if err != nil {
return nil, xerrors.Errorf("insert template version terraform data: %w", err)
}

err = s.Database.UpdateProvisionerJobWithCompleteByID(ctx, database.UpdateProvisionerJobWithCompleteByIDParams{
ID: jobID,
Expand Down
Loading
0