fix: update WorkspacesEmpty.tsx from material ui to tailwind
#16886
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
@brettkolodny can you help review this PR? |
|
I have read the CLA Document and I hereby sign the CLA |
WorkspacesEmpty.tsx from material ui to tailwind
| backgroundColor: theme.palette.background.paper, | ||
| }, | ||
| })} | ||
| className="w-[320px] p-4 rounded-md border border-divider text-left flex gap-4 no-underline text-inherit hover:bg-paper" |
There was a problem hiding this comment.
the old theme.palette.divider and theme.palette.background.paper colors haven't been carried over from material ui to tailwind, so border-divider and hover:bg-paper are not actually valid classes.
if you look at the failing chromatic tests, you can see what it looked like before and what it looks like now. you can see the set of available tailwind colors in our tailwind.config.js file, and their actual values in index.css. the match doesn't have to be exact, but the colors should be close.
There was a problem hiding this comment.
Updated the colors to the closest that I could see which was border-surface-grey.
|
Looking good after those color changed! |
|
Took another look at the code this morning and saw the colors were a little off and found better matching ones. |
|
looks good! thank you! |
Attached screenshots of code that I updated on WorkspacesEmpty.tsx
