-
Notifications
You must be signed in to change notification settings - Fork 929
feat: add provisioner jobs into the UI #16867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2e1ebb3
feat: add provisioner jobs
BrunoQuaresma d931c4a
Add tests and refactor location
BrunoQuaresma 2abe99b
Merge branch 'main' of https://github.com/coder/coder into bq/provisi…
BrunoQuaresma 912cd8f
FMT
BrunoQuaresma a56246f
Apply Kaylas suggestions
BrunoQuaresma 8a62ecc
Apply Kaylas suggestion
BrunoQuaresma 901ab23
Remove injection
BrunoQuaresma ed73594
FMT
BrunoQuaresma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
58 changes: 58 additions & 0 deletions
58
site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/JobRow.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import type { Meta, StoryObj } from "@storybook/react"; | ||
| import { expect, userEvent, waitFor, within } from "@storybook/test"; | ||
| import { Table, TableBody } from "components/Table/Table"; | ||
| import { MockProvisionerJob } from "testHelpers/entities"; | ||
| import { daysAgo } from "utils/time"; | ||
| import { JobRow } from "./JobRow"; | ||
|
|
||
| const meta: Meta<typeof JobRow> = { | ||
| title: "pages/OrganizationProvisionerJobsPage/JobRow", | ||
| component: JobRow, | ||
| args: { | ||
| job: { | ||
BrunoQuaresma marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ...MockProvisionerJob, | ||
| created_at: daysAgo(2), | ||
| }, | ||
| }, | ||
| render: (args) => { | ||
| return ( | ||
| <Table> | ||
| <TableBody> | ||
| <JobRow {...args} /> | ||
| </TableBody> | ||
| </Table> | ||
| ); | ||
| }, | ||
| }; | ||
|
|
||
| export default meta; | ||
| type Story = StoryObj<typeof JobRow>; | ||
|
|
||
| export const Close: Story = {}; | ||
|
|
||
| export const OpenOnClick: Story = { | ||
| play: async ({ canvasElement, args }) => { | ||
| const canvas = within(canvasElement); | ||
| const showMoreButton = canvas.getByRole("button", { name: /show more/i }); | ||
|
|
||
| await userEvent.click(showMoreButton); | ||
|
|
||
| const jobId = canvas.getByText(args.job.id); | ||
| expect(jobId).toBeInTheDocument(); | ||
| }, | ||
| }; | ||
|
|
||
| export const HideOnClick: Story = { | ||
| play: async ({ canvasElement, args }) => { | ||
| const canvas = within(canvasElement); | ||
|
|
||
| const showMoreButton = canvas.getByRole("button", { name: /show more/i }); | ||
| await userEvent.click(showMoreButton); | ||
|
|
||
| const hideButton = canvas.getByRole("button", { name: /hide/i }); | ||
| await userEvent.click(hideButton); | ||
|
|
||
| const jobId = canvas.queryByText(args.job.id); | ||
| expect(jobId).not.toBeInTheDocument(); | ||
| }, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
...s/OrganizationSettingsPage/OrganizationProvisionerJobsPage/JobStatusIndicator.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| import type { Meta, StoryObj } from "@storybook/react"; | ||
| import { MockProvisionerJob } from "testHelpers/entities"; | ||
| import { JobStatusIndicator } from "./JobStatusIndicator"; | ||
|
|
||
| const meta: Meta<typeof JobStatusIndicator> = { | ||
| title: "pages/OrganizationProvisionerJobsPage/JobStatusIndicator", | ||
| component: JobStatusIndicator, | ||
| }; | ||
|
|
||
| export default meta; | ||
| type Story = StoryObj<typeof JobStatusIndicator>; | ||
|
|
||
| export const Succeeded: Story = { | ||
| args: { | ||
| job: { | ||
| ...MockProvisionerJob, | ||
| status: "succeeded", | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export const Failed: Story = { | ||
| args: { | ||
| job: { | ||
| ...MockProvisionerJob, | ||
| status: "failed", | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export const Pending: Story = { | ||
| args: { | ||
| job: { | ||
| ...MockProvisionerJob, | ||
| status: "pending", | ||
| queue_position: 1, | ||
| queue_size: 1, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export const Running: Story = { | ||
| args: { | ||
| job: { | ||
| ...MockProvisionerJob, | ||
| status: "running", | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export const Canceling: Story = { | ||
| args: { | ||
| job: { | ||
| ...MockProvisionerJob, | ||
| status: "canceling", | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export const Canceled: Story = { | ||
| args: { | ||
| job: { | ||
| ...MockProvisionerJob, | ||
| status: "canceled", | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export const Unknown: Story = { | ||
| args: { | ||
| job: { | ||
| ...MockProvisionerJob, | ||
| status: "unknown", | ||
| }, | ||
| }, | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this sugg
3008
estion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.