8000 fix: use correct permissions for CRUD of custom roles by jaaydenh · Pull Request #16854 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: use correct permissions for CRUD of custom roles #16854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

fix: use correct permissions for CRUD of custom roles #16854

merged 2 commits into from
Mar 10, 2025

Conversation

jaaydenh
Copy link
Contributor
@jaaydenh jaaydenh commented Mar 7, 2025 •
edited
Loading

resolves coder/internal#428

The goal of the PR is to start using updateOrgRoles and deleteOrgRoles permissions to gate custom roles functionality

		updateOrgRoles: {
			object: {
				resource_type: "assign_org_role",
				organization_id: organizationId,
			},
			action: "update",
		},
		deleteOrgRoles: {
			object: {
				resource_type: "assign_org_role",
				organization_id: organizationId,
			},
			action: "delete",
		}

@jaaydenh jaaydenh self-assigned this Mar 7, 2025
@jaaydenh jaaydenh requested a review from aslilac March 7, 2025 23:08
aslilac
aslilac approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member
@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! this is a tremendous bit of permission cleanup, thank you for the help 😄

@jaaydenh jaaydenh merged commit 86b61ef into main Mar 10, 2025
30 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/custom-roles-permissions branch March 10, 2025 22:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

Assignees

@jaaydenh jaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orgs: User admins should not see UI to edit or create roles in the UI
2 participants
@jaaydenh @aslilac
0