8000 chore: set default requests/limits in helm chart by ericpaulsen · Pull Request #16844 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: set default requests/limits in helm chart #16844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025
Merged

chore: set default requests/limits in helm chart #16844

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dfbddd6
helm: set default requests/limits
ericpaulsen Mar 7, 2025
323ebd4
conditional logic for default resource values
ericpaulsen Mar 11, 2025
c3327d3
helm: add test cases for custom resource limits and requests
ericpaulsen Mar 17, 2025
2376d54
add test cases for provisioner chart
ericpaulsen Mar 18, 2025
a7609ab
Merge branch 'main' into default-reqs-limits
ericpaulsen Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations 8000
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
conditional logic for default resource values
  • Loading branch information
@ericpaulsen
ericpaulsen committed Mar 11, 2025
commit 323ebd4e9208a75964657048d633196e0cd2239b
12 changes: 6 additions & 6 deletions helm/coder/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,12 @@ coder:
# coder.resources -- The resources to request for Coder. The below values are
# defaults and can be overridden.
resources:
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
# limits:
# cpu: 2000m
# memory: 4096Mi
# requests:
# cpu: 2000m
# memory: 4096Mi

# coder.certs -- CA bundles to mount inside the Coder pod.
certs:
Expand Down
11 changes: 10 additions & 1 deletion helm/libcoder/templates/_coder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,16 @@ imagePullPolicy: {{ .Values.coder.image.pullPolicy }}
command:
{{- toYaml .Values.coder.command | nindent 2 }}
resources:
{{- toYaml .Values.coder.resources | nindent 2 }}
{{- if and (hasKey .Values.coder "resources") (not (empty .Values.coder.resources)) }}
{{- toYaml .Values.coder.resources | nindent 2 }}
{{- else }}
limits:
cpu: 2000m
memory: 4096Mi
requests:
cpu: 2000m
memory: 4096Mi
{{- end }}
lifecycle:
{{- toYaml .Values.coder.lifecycle | nindent 2 }}
securityContext: {{ toYaml .Values.coder.securityContext | nindent 2 }}
Expand Down
Loading
0