8000 feat: include winres metadata in Windows binaries (cherry-pick #16706) by matifali · Pull Request #16742 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: include winres metadata in Windows binaries (cherry-pick #16706) #16742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 28, 2025
Merged

feat: include winres metadata in Windows binaries (cherry-pick #16706) #16742

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85e2a6a
feat: include winres metadata in Windows binaries
deansheather Feb 26, 2025
d2c54b3
test CI
deansheather Feb 26, 2025
cf9fc04
fix: add permission for gcloud auth
deansheather Feb 26, 2025
970bf8a
test CI 2
deansheather Feb 26, 2025
35dc760
Revert "test CI 2"
deansheather Feb 26, 2025
5d9c439
Revert "test CI"
deansheather Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
8000
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "test CI" 
This reverts commit d2c54b3.
  • Loading branch information
@deansheather
deansheather committed Feb 26, 2025
commit 5d9c439694bd6c8e211cb2b65fd29b686b93805f
5 changes: 2 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,7 @@ jobs:
needs:
- changes
- build-dylib
#if: github.ref == 'refs/heads/main' && needs.changes.outputs.docs-only == 'false' && !github.event.pull_request.head.repo.fork
if: github.ref == 'refs/heads/main' && needs.changes.outputs.docs-only == 'false' && !github.event.pull_request.head.repo.fork
runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-22.04' }}
permissions:
# Necessary to push docker images to ghcr.io.
Expand Down Expand Up @@ -1131,7 +1131,6 @@ jobs:
JSIGN_PATH: /tmp/jsign-6.0.jar

- name: Build Linux Docker images
if: github.ref == 'refs/heads/main'
id: build-docker
env:
CODER_IMAGE_BASE: ghcr.io/coder/coder-preview
Expand Down Expand Up @@ -1187,7 +1186,7 @@ jobs:
prune-untagged: true

- name: Upload build artifacts
#if: github.ref == 'refs/heads/main'
if: github.ref == 'refs/heads/main'
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4.6.1
with:
name: coder
Expand Down
Loading
0