8000 fix: add org role read permissions to site wide template admins and auditors by jaaydenh · Pull Request #16733 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: add org role read permissions to site wide template admins and auditors #16733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix: add org role read permissions to site wide template admins and auditors #16733

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3db217
fix: add org role read permissions
jaaydenh Feb 27, 2025
b2ac466
fix: fix ReadOrgRoleAssignment test
jaaydenh Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: fix ReadOrgRoleAssignment test
  • Loading branch information
@jaaydenh
jaaydenh committed Feb 27, 2025
commit b2ac4661439c48a51956f36ae922d166e55d2c74
4 changes: 2 additions & 2 deletions coderd/rbac/roles_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,8 +352,8 @@ func TestRolePermissions(t *testing.T) {
Actions: []policy.Action{policy.ActionRead},
Resource: rbac.ResourceAssignOrgRole.InOrg(orgID),
AuthorizeMap: map[bool][]hasAuthSubjects{
true: {owner, setOrgNotMe, orgMemberMe, userAdmin},
false: {setOtherOrg, memberMe, templateAdmin},
true: {owner, setOrgNotMe, orgMemberMe, userAdmin, templateAdmin},
false: {setOtherOrg, memberMe},
},
},
{
Expand Down
Loading
0