8000 chore: run `make clean` on workspace startup by aslilac · Pull Request #16660 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: run make clean on workspace startup #16660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025
Merged

chore: run make clean on workspace startup #16660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21dbd3d
chore: run `make clean` on workspace shutdown
aslilac Feb 21, 2025
25aed29
on startup actually
aslilac Feb 21, 2025
fdf7880
bump usage threshold
aslilac Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ endif

clean:
rm -rf build/ site/build/ site/out/
mkdir -p build/ site/out/bin/
mkdir -p build/
git restore site/out/
.PHONY: clean

Expand Down
3 changes: 2 additions & 1 deletion dogfood/contents/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ data "coder_parameter" "res_mon_memory_threshold" {
data "coder_parameter" "res_mon_volume_threshold" {
type = "number"
name = "Volume usage threshold"
default = 80
default = 90
description = "The volume usage threshold used in resources monitoring to trigger notifications."
mutable = true
}
Expand Down Expand Up @@ -342,6 +342,7 @@ resource "coder_agent" "dev" {
while ! [[ -f "${local.repo_dir}/site/package.json" ]]; do
sleep 1
done
cd "${local.repo_dir}" && make clean
cd "${local.repo_dir}/site" && pnpm install && pnpm playwright:install
EOT
}
Expand Down
Loading
0