8000 feat(agent): add connection reporting for SSH and reconnecing PTY by mafredri · Pull Request #16652 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat(agent): add connection reporting for SSH and reconnecing PTY #16652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 27, 2025
Merged

feat(agent): add connection reporting for SSH and reconnecing PTY #16652

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
58463c6
feat(agent): add connection reporting for SSH and reconnecing PTY
mafredri Feb 21, 2025
a77ceac
chore: put connection reports behind experimental flag
mafredri Feb 24, 2025
17ddb8e
simplify
mafredri Feb 24, 2025
82b6fab
net.SplitHostPort
mafredri Feb 24, 2025
4166c29
Merge branch 'main' into mafredri/feat-add-agent-connection-reporting
mafredri Feb 27, 2025
0318212
add buffer limit
mafredri Feb 27, 2025
d47e8a4
release pointer
mafredri Feb 27, 2025
601b6f4
typo
mafredri Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
release pointer
  • Loading branch information
@mafredri
mafredri committed Feb 27, 2025
commit d47e8a4616e539be781fa127c898e175451cd973
1 change: 1 addition & 0 deletions agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,7 @@ func (a *agent) reportConnectionsLoop(ctx context.Context, aAPI proto.DRPCAgentC

// Remove the payload we sent.
a.reportConnectionsMu.Lock()
a.reportConnections[0] = nil // Release the pointer from the underlying array.
a.reportConnections = a.reportConnections[1:]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just make reportConnections channel? If it's an append only slice that is only read in this function.

This slice behavior is correct, just feels like a weaker implementation of a channel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it could be a channel, but how big to make it? How many in-flight reports is "too many"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair, a channel would not be a terrible option here. It requires upfront allocation which can either be a good or a bad thing in memory constrained systems. For now I've limited this to 2048 reports pending, or about 300KB. We can revisit this later if needed.

a.reportConnectionsMu.Unlock()
}
Expand Down
Loading
0