8000 chore: add resources_monitoring to dogfood by defelmnq · Pull Request #16600 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

chore: add resources_monitoring to dogfood #16600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 19, 2025
Merged

Conversation

defelmnq
Copy link
Contributor

As we recently merged OOM & OOD Notifications - we can now enable it in the dogfood instance and workspaces so everyone can use it and help testing it.

@defelmnq defelmnq self-assigned this Feb 18, 2025
@defelmnq defelmnq marked this pull request as ready for review February 18, 2025 10:37
@defelmnq
Copy link
Contributor Author

I updated the resources monitoring as suggested by @dannykopping to use parameters instead of any hardcoded value. Here's what it looks like - it obviously makes sense only for dogfood instance but would help us testing it.

Screenshot 2025-02-19 at 06 55 08

Copy link
Contributor
@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@defelmnq defelmnq merged commit 52cc0ce into main Feb 19, 2025
28 checks passed
@defelmnq defelmnq deleted the notifications-dogfood branch February 19, 2025 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
Copy link
Member
@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge approval! :shipit:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0