8000 fix: stop text from overflowing on delete org button by brettkolodny · Pull Request #16549 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: stop text from overflowing on delete org button #16549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 14, 2025
Merged

fix: stop text from overflowing on delete org button #16549

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2dcde96
chore: convert styles to tailwind
brettkolodny Feb 12, 2025
a859e81
fix: match colors closer to original designs
brettkolodny Feb 12, 2025
02a7589
fix: set min width on button to stop overflow
brettkolodny Feb 12, 2025
44d9fbf
fix: format
brettkolodny Feb 12, 2025
d90e20d
fix: remove unused classes
brettkolodny Feb 12, 2025
8d57a44
Merge branch 'main' into brett/fix-text-overflow-on-delete-button
brettkolodny Feb 14, 2025
5171653
fix: remove hard coded tailwind values
brettkolodny Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove unused classes
  • Loading branch information
@brettkolodny
brettkolodny committed Feb 12, 2025
commit d90e20d0790f754b1b3010afc54d5ac8b6fa00bf
2 changes: 1 addition & 1 deletion site/src/pages/OrganizationSettingsPage/OrganizationSettingsPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export const OrganizationSettingsPageView: FC<
title="Settings"
description="Change or delete your organization."
>
<div className="flex bg-surface-orange items-center justify-between border border-solid border-orange-600 rounded-[8px] p-3 pl-[18px] gap-2 flex-grow //flex-wrap">
<div className="flex bg-surface-orange items-center justify-between border border-solid border-orange-600 rounded-[8px] p-3 pl-[18px] gap-2 flex-grow">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually avoid setting explicit styles with Tailwind as much as possible.

For rounded-, there actually will be some work in the future to update these in the tailwind.config. If this is set to rounded-md it will automatically gets that update and therefore the consistency in the future.

For pl-[18px], it would be better to just choose one of the closest classes either pl-4 or pl-5

In general, we should only use the explicit styling if that was a decision made in the Figma designs or the utility class options are really too different from what looks correct.

<span>Deleting an organization is irreversible.</span>
<Button
variant="destructive"
Expand Down
Loading
0