clarify query clause

coder · dannykopping · Mar 12, 2025 · Mar 12, 2025 · Mar 12, 2025 · Mar 12, 2025
commit 097f9c38d7ef0ea23f43d94277f9247df8491357
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/prebuilds.sql b/coderd/database/queries/prebuilds.sql
@@ -99,18 +99,21 @@ UPDATE workspaces w
 SET owner_id   = @new_user_id::uuid,
 	name       = @new_name::text,
 	updated_at = NOW()
-WHERE w.id IN (SELECT p.id
-			   FROM workspace_prebuilds p
-						INNER JOIN workspace_latest_builds b ON b.workspace_id = p.id
-						INNER JOIN provisioner_jobs pj ON b.job_id = pj.id
-						INNER JOIN templates t ON p.template_id = t.id
-			   WHERE (b.transition = 'start'::workspace_transition
-				   AND pj.job_status IN ('succeeded'::provisioner_job_status))
-				 AND b.template_version_id = t.active_version_id
-				 AND b.template_version_preset_id = @preset_id::uuid
-				 AND p.ready
-			   ORDER BY random()
-			   LIMIT 1 FOR UPDATE OF p SKIP LOCKED) -- Ensure that a concurrent request will not select the same prebuild.
+WHERE w.id IN (
+	SELECT p.id
+	FROM workspace_prebuilds p
+		INNER JOIN workspace_latest_builds b ON b.workspace_id = p.id
+		INNER JOIN provisioner_jobs pj ON b.job_id = pj.id
+		INNER JOIN templates t ON p.template_id = t.id
+	WHERE (b.transition = 'start'::workspace_transition
+		AND pj.job_status IN ('succeeded'::provisioner_job_status))
+	-- The prebuilds system should never try to claim a prebuild for an inactive template version.
+	-- Nevertheless, this filter is here as a defensive measure:
+	AND b.template_version_id = t.active_version_id
+	AND b.template_version_preset_id = @preset_id::uuid
+	AND p.ready
+	LIMIT 1 FOR UPDATE OF p SKIP LOCKED -- Ensure that a concurrent request will not select the same prebuild.
+)
 RETURNING w.id, w.name;
 
 -- name: GetPrebuildMetrics :many