8000 feat: add sourcing secondary claims from access_token by Emyrk · Pull Request #16517 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: add sourcing secondary claims from access_token #16517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 24, 2025
Merged

feat: add sourcing secondary claims from access_token #16517

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4275b3
feat(oidc): add sourcing secondary claims from access_token
Emyrk Feb 10, 2025
895bb00
test(oidc): test sourcing secondary claims from access token
Emyrk Feb 10, 2025
eee85c0
make gen
Emyrk Feb 10, 2025
c2b3868
update golden files
Emyrk Feb 10, 2025
b89084f
revert change to sub check
Emyrk Feb 10, 2025
11f4bcc
update error message
Emyrk Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert change to sub check
  • Loading branch information
@Emyrk
Emyrk committed Feb 10, 2025
commit b89084f70cf372c1d94ddcfbea870069543abf9b
14 changes: 14 additions & 0 deletions coderd/userauth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,6 +1122,20 @@ func (api *API) userOIDC(rw http.ResponseWriter, r *http.Request) {
return
}

if idToken.Subject == "" {
logger.Error(ctx, "oauth2: missing 'sub' claim field in OIDC token",
slog.F("source", "id_token"),
slog.F("claim_fields", claimFields(idtokenClaims)),
slog.F("blank", blankFields(idtokenClaims)),
)
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
Message: "OIDC token missing 'sub' claim field or 'sub' claim field is empty.",
Detail: "'sub' claim field is required to be unique for all users by a given issue, " +
"an empty field is invalid and this authentication attempt is rejected.",
})
return
}

logger.Debug(ctx, "got oidc claims",
slog.F("source", "id_token"),
slog.F("claim_fields", claimFields(idtokenClaims)),
Expand Down
Loading
0