8000 fix(provisioner/terraform/tfparse): allow empty values in coder_workspace_tag defaults by johnstcn · Pull Request #16303 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix(provisioner/terraform/tfparse): allow empty values in coder_workspace_tag defaults #16303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025
Merged

fix(provisioner/terraform/tfparse): allow empty values in coder_workspace_tag defaults #16303

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
413d1c8
fix(provisioner/terraform/tfparse): allow empty values in coder_works…
johnstcn Jan 27, 2025
85a168e
chore(coderdenttest): use random name instead of t.Name() in newExter…
johnstcn Jan 27, 2025
ecb2ffd
chore(docs): update docs re workspace tag default values
johnstcn Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore(docs): update docs re workspace tag default values
  • Loading branch information
@johnstcn
johnstcn committed Jan 27, 2025
commit ecb2ffd963b5f2f93b5d993e75fa6dae5be4f6b5
7 changes: 1 addition & 6 deletions docs/admin/templates/extending-templates/workspace-tags.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@ variables and parameters. This is illustrated in the table below:

## Constraints

### Default Values

All template variables and `coder_parameter` data sources **must** provide a
default value. Failure to do so will result in an error.

### Tagged provisioners

It is possible to choose tag combinations that no provisioner can handle. This
Expand Down Expand Up @@ -127,6 +122,6 @@ variables, and references to other resources.

#### Not supported

- Function calls: `try(var.foo, "default")`
- Function calls that reference files on disk: `abspath`, `file*`, `pathexpand`
- Resources: `compute_instance.dev.name`
- Data sources other than `coder_parameter`: `data.local_file.hostname.content`
6 changes: 2 additions & 4 deletions examples/workspace-tags/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ icon: /icon/docker.png

## Overview

This Coder template presents use of [Workspace Tags](https://coder.com/docs/templates/workspace-tags) [Coder Parameters](https://coder.com/docs/templates/parameters).
This Coder template presents use of [Workspace Tags](https://coder.com/docs/admin/templates/extending-templates/workspace-tags) and [Coder Parameters](https://coder.com/docs/templates/parameters).

## Use case

Expand All @@ -18,10 +18,8 @@ By using `coder_workspace_tags` and `coder_parameter`s, template administrators
## Notes

- You will need to have an [external provisioner](https://coder.com/docs/admin/provisioners#external-provisioners) with the correct tagset running in order to import this template.
- When specifying values for the `coder_workspace_tags` data source, you are restricted to using a subset of Terraform's capabilities.
- You must specify default values for all data sources and variables referenced by the `coder_workspace_tags` data source.
- When specifying values for the `coder_workspace_tags` data source, you are restricted to using a subset of Terraform's capabilities. See [here](https://coder.com/docs/admin/templates/extending-templates/workspace-tags) for more details.

See [Workspace Tags](https://coder.com/docs/templates/workspace-tags) for more information.

## Development

Expand Down
Loading
0