8000 feat: improve metrics and UI for user engagement on the platform by BrunoQuaresma · Pull Request #16134 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: improve metrics and UI for user engagement on the platform #16134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 17, 2025
Merged

feat: improve metrics and UI for user engagement on the platform #16134

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
899e88f
WIP: Setup base users count chart
BrunoQuaresma Jan 13, 2025
3d652ee
Merge branch 'main' of https://github.com/coder/coder into bq/user-eg…
BrunoQuaresma Jan 14, 2025
034c359
Implement User Engagement component
BrunoQuaresma Jan 14, 2025
8eba4d4
Integrate chart with API data
BrunoQuaresma Jan 14, 2025
2238590
Run lint and format
BrunoQuaresma Jan 14, 2025
8373732
Update story to show active data
BrunoQuaresma Jan 14, 2025
dc0261f
Merge branch 'main' of https://github.com/coder/coder into bq/user-eg…
BrunoQuaresma Jan 15, 2025
090230d
Adjust a few design topics from Chrsitin
BrunoQuaresma Jan 15, 2025
c454eba
Use DAU for user engagement chart
BrunoQuaresma Jan 16, 2025
e2cf922
Merge branch 'main' of https://github.com/coder/coder into bq/user-eg…
BrunoQuaresma Jan 16, 2025
4b7bf9f
Adjust engagement chart
BrunoQuaresma Jan 16, 2025
e036f94
Add license consumption chart
BrunoQuaresma Jan 16, 2025
372649b
Add storybook for license chart
BrunoQuaresma Jan 16, 2025
a88da96
Remove text-ms
BrunoQuaresma Jan 16, 2025
39ee475
Run make fmt
BrunoQuaresma Jan 16, 2025
11ce947
Adjust charts
BrunoQuaresma Jan 17, 2025
c2e7b95
Fix format
BrunoQuaresma Jan 17, 2025
f38361e
Fix stories
BrunoQuaresma Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add storybook for license chart
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Jan 16, 2025
commit 372649b2138db0560e83f6141d80436a902ead1a
37 changes: 37 additions & 0 deletions ...pages/DeploymentSettingsPage/LicensesSettingsPage/LicenseSeatConsumptionChart.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import type { Meta, StoryObj } from "@storybook/react";
import { LicenseSeatConsumptionChart } from "./LicenseSeatConsumptionChart";

const meta: Meta<typeof LicenseSeatConsumptionChart> = {
title:
"pages/DeploymentSettingsPage/LicensesSettingsPage/LicenseSeatConsumptionChart",
component: LicenseSeatConsumptionChart,
args: {
limit: 220,
data: [
{ date: "1/1/2024", users: 150 },
{ date: "1/2/2024", users: 165 },
{ date: "1/3/2024", users: 180 },
{ date: "1/4/2024", users: 155 },
{ date: "1/5/2024", users: 190 },
{ date: "1/6/2024", users: 200 },
{ date: "1/7/2024", users: 210 },
],
},
};

export default meta;
type Story = StoryObj<typeof LicenseSeatConsumptionChart>;

export const Loaded: Story = {};

export const Empty: Story = {
args: {
data: [],
},
};

export const Loading: Story = {
args: {
data: undefined,
},
};
5 changes: 4 additions & 1 deletion site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/LicenseSeatConsumptionChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ export const LicenseSeatConsumptionChart: FC<
}
/>
<YAxis
// Adds space on Y to show always show the reference line without overflowing it.
domain={[0, limit ? "dataMax + 10" : "auto"]}
dataKey="users"
tickLine={false}
axisLine={false}
Expand Down Expand Up @@ -199,8 +201,9 @@ export const LicenseSeatConsumptionChart: FC<
/>
{limit && (
<ReferenceLine
isFront
ifOverflow="extendDomain"
y={70}
y={limit}
label={{
value: "license seat limit",
position: "insideBottomRight",
Expand Down
0