8000 fix(scripts/coder-dev.sh): silence output if stdout is not a TTY by johnstcn · Pull Request #16131 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix(scripts/coder-dev.sh): silence output if stdout is not a TTY #16131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix(scripts/coder-dev.sh): silence output if stdout is not a TTY #16131

merged 1 commit into from
Jan 14, 2025

Conversation

johnstcn
Copy link
Member

The make -j output was sometimes emitting non-JSON output from go generate, resulting in errors like the below:

++ /home/coder/src/coder/coder/scripts/coder-dev.sh organizations show me -o json
++ jq -r '.[] | select(.is_default) | .name'
parse error: Invalid numeric literal at line 1, column 3

This PR modifies coder-dev.sh to silence the output of make if the output is not a TTY.

@johnstcn johnstcn requested a review from mafredri January 14, 2025 13:40
@johnstcn johnstcn self-assigned this Jan 14, 2025
@johnstcn johnstcn changed the title fix(scripts/develop.sh): silence output if stdout is not a TTY fix(scripts/coder-dev.sh): silence output if stdout is not a TTY Jan 14, 2025
@johnstcn johnstcn requested a review from dannykopping January 14, 2025 14:31
@johnstcn johnstcn merged commit d7809ec into main Jan 14, 2025
35 checks passed
@johnstcn johnstcn deleted the cj/coder-dev-stdout branch January 14, 2025 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request 3810 may close these issues.
2 participants
@johnstcn @dannykopping
0