8000 feat: notify on workspace update by DanielleMaywood · Pull Request #15979 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: notify on workspace update #15979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 2, 2025
Merged

feat: notify on workspace update #15979

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
541b852
add notification on workspace update
DanielleMaywood Dec 30, 2024
835e49c
tests: test expectations
DanielleMaywood Dec 30, 2024
b43a7e6
chore: change error message, add error log
DanielleMaywood Dec 31, 2024
c683985
chore: apply feedback
DanielleMaywood Dec 31, 2024
b3707a1
fix: broken logic
DanielleMaywood Dec 31, 2024
7f10ecc
chore: wrap in transaction
DanielleMaywood Jan 2, 2025
1a493ff
chore: remove whitespace between call and return err
DanielleMaywood Jan 2, 2025
32adc00
chore: actually use the transaction, oops
DanielleMaywood Jan 2, 2025
90380f7
chore: changes
DanielleMaywood Jan 2, 2025
71ec1ac
chore: move prep of builder and notify out of tx
DanielleMaywood Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: broken logic
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Dec 31, 2024
commit b3707a163eb2dc2be296d20e1affa5236fc61e1d
2 changes: 1 addition & 1 deletion coderd/workspacebuilds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ func (api *API) notifyWorkspaceUpdated(
return
}

version, err := api.Database.GetTemplateVersionByID(ctx, workspace.TemplateID)
version, err := api.Database.GetTemplateVersionByID(ctx, template.ActiveVersionID)
if err != nil {
log.Warn(ctx, "failed to fetch template version for workspace creation notification", slog.F("template_id", workspace.TemplateID), slog.Error(err))
return
Expand Down
Loading
0