10000 chore: adopt markdownlint and markdown-table-formatter for *.md by matifali · Pull Request #15831 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

chore: adopt markdownlint and markdown-table-formatter for *.md #15831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 94 commits into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
fe34c79
disable prettier for docs md
EdwardAngert Nov 25, 2024
5d1429a
make fmt
EdwardAngert Nov 25, 2024
a8b2217
fix md in jfrog-artifactory
EdwardAngert Nov 25, 2024
8df4ea1
Merge remote-tracking branch 'origin/main' into 216-disable-prettier-…
Dec 5, 2024
819074c
add markdownlint-cli2 and rules
Dec 5, 2024
150fdef
make fmt
Dec 5, 2024
4a1fb29
fix typo
Dec 5, 2024
acee64b
alt text to contributors
Dec 5, 2024
9109a7e
Apply suggestions from code review
EdwardAngert Dec 6, 2024
a6b8f83
move action; remove output format
Dec 6, 2024
6e8aa60
link fixes
Dec 6, 2024
9f14438
fixes and ignore no-bare-urls
Dec 6, 2024
40a94f1
md fixes
Dec 6, 2024
43435a5
add changed.yml
Dec 9, 2024
1da5f23
md lint changed files
Dec 9, 2024
59a92c9
remove redundancy from docs-pr.yaml
Dec 9, 2024
34ca8cb
mdlinter ignore docs/reference
EdwardAngert Dec 10, 2024
4dc14ea
fix errors
EdwardAngert Dec 10, 2024
b7331df
Merge branch 'main' into 216-disable-prettier-docs-md
matifali Dec 11, 2024
fcaa917
Integrate markdownlint and remove Prettier for docs
matifali Dec 11, 2024
e9431a6
Refactor docs lint workflow in docs-lint.yaml
matifali Dec 11, 2024
2f84e0f
Update docs lint workflow to include site directory
matifali Dec 11, 2024
e3ac0b1
Add packageManager to site package.json
matifali Dec 11, 2024
9ccfcfd
Refactor actions and workflows for consistency
matifali Dec 11, 2024
7d5b411
Remove pnpm-lock.yaml from version control
matifali Dec 11, 2024
3b396d3
Fix markdown lint issues in docs and Makefile
matifali Dec 11, 2024
44ceda1
Remove comment line handling in example parsing
matifali Dec 11, 2024
847a8f3
Quote markdownlint path globs in Makefile
matifali Dec 11, 2024
4ed47fc
Fix formatting in provisionerGenerated.ts
matifali Dec 11, 2024
89fec9a
Merge remote-tracking branch 'origin/main' into 216-disable-prettier-…
EdwardAngert Dec 11, 2024
6d5006a
Refactor TypeScript formatting target in Makefile
matifali Dec 12, 2024
0471071
Refactor Makefile to rename fmt/ts to fmt/biome
matifali Dec 12, 2024
981d7b5
Refactor documentation for consistency in formatting
matifali Dec 12, 2024
d11102a
Rename docs-lint.yaml to docs-ci.yaml
matifali Dec 12, 2024
e14d543
Discard changes to .github/actions/setup-node/action.yaml
matifali Dec 12, 2024
f1305d0
Discard changes to coderd/prometheusmetrics/testdata/agent-stats.json
matifali Dec 12, 2024
3670fa7
Discard changes to coderd/prometheusmetrics/insights/testdata/insight…
matifali Dec 12, 2024
e1eec2f
revert non-docs chnages
matifali Dec 12, 2024
f3652f7
remove prettier
matifali Dec 12, 2024
34ceccf
ignore examples.gen.json
matifali Dec 12, 2024
868d3fa
Merge branch '216-disable-prettier-docs-md' into atif/bye-bye-prettier
matifali Dec 12, 2024
3c2c4da
Merge branch 'main' into atif/bye-bye-prettier
matifali Dec 12, 2024
8cdd668
Update markdown formatting tools and apply fixes
matifali Dec 12, 2024
223cd4d
ci: specify workspace directory in setup-node action
matifali Dec 12, 2024
6de5e1d
Add Storybook launch script to package.json
matifali Dec 12, 2024
2ed285f
Rename docs lint workflow to docs CI
matifali Dec 12, 2024
eb3504c
Remove redundant setup-node configuration
matifali Dec 12, 2024
7b7308b
Add echo for changed files in docs CI workflow
matifali Dec 12, 2024
95d5574
Fix workflow environment variable syntax in docs CI
matifali Dec 12, 2024
d8fb439
Swap lint and fmt steps in docs workflow
matifali Dec 12, 2024
db200bb
Rename workflow job to 'docs' in docs-ci.yaml
matifali Dec 12, 2024
60a5a4a
Improve markdown formatting consistency
matifali Dec 12, 2024
691cf5c
Refactor JSON example tags formatting and add comment
matifali Dec 12, 2024
c9afb8b
Add generated examples for various environments
matifali Dec 12, 2024
79abf5f
Merge branch 'main' into atif/bye-bye-prettier
matifali Dec 17, 2024
7a326bd
8000 `make fmt`
matifali Dec 17, 2024
f6c652a
Resolve merge conflict by incorporating both suggestions
matifali Dec 23, 2024
ab64ced
fix glob
matifali Dec 23, 2024
fd042dd
fix glob
matifali Dec 23, 2024
c9bc320
fixup: remove extra examples.gen.json from root
matifali Dec 23, 2024
a38312a
JSON do not have commnets
matifali Dec 23, 2024
3417860
remove target for ignored file
matifali Dec 23, 2024
bd31583
make -B
matifali Dec 23, 2024
9b0f28a
fixup
matifali Dec 24, 2024
917d6b3
Merge branch 'main' into atif/bye-bye-prettier
matifali Dec 24, 2024
ad73e4e
fixup
matifali Dec 24, 2024
90acaca
Reorder and update VSCode extension recommendations
matifali Dec 27, 2024
979a283
enable more rules
matifali Dec 27, 2024
34aa71b
Merge branch 'main' into atif/bye-bye-prettier
matifali Dec 27, 2024
6abc05a
make gen
matifali Dec 27, 2024
a291686
make fmt
matifali Dec 27, 2024
a61d20d
golden files
matifali Dec 30, 2024
e384d0a
Merge branch 'main' into atif/bye-bye-prettier
matifali Dec 30, 2024
f0cb88d
Update URLs to angle brackets for Markdown
matifali Dec 30, 2024
4e83922
Update codersdk/deployment.go
matifali Dec 31, 2024
504a1ed
Update docs/changelogs/v2.1.1.md
matifali Dec 31, 2024
4cea376
Update docs/changelogs/v2.5.0.md
matifali Dec 31, 2024
1637783
Merge branch 'main' into atif/bye-bye-prettier
matifali Dec 31, 2024
5392bb7
fix heading levels in IDP sync documentation
matifali Dec 31, 2024
15f21eb
Update docs CI workflow for specific file paths
matifali Dec 31, 2024
b733ad1
Format code examples in docs with backticks
matifali Dec 31, 2024
0d41834
Update workflow paths for consistent globbing
matifali Dec 31, 2024
f97ce22
Merge branch 'main' into atif/bye-bye-prettier
matifali Jan 2, 2025
687b015
wip
matifali Jan 2, 2025
fe265eb
wip 2
matifali Jan 2, 2025
33f4b81
fixup
matifali Jan 2, 2025
11dd374
Update markdownlint config for schema and templates docs
matifali Jan 2, 2025
43f568b
Merge branch 'main' into atif/bye-bye-prettier
matifali Jan 3, 2025
dadc689
make -B gen
matifali Jan 3, 2025
c375423
Delete coderd/database/dbmock/gomock_reflect_2684282611/prog.go
matifali Jan 3, 2025
6b95860
make -B gen
matifali Jan 3, 2025
8fefeef
make -B gen
matifali Jan 3, 2025
8731666
make update-golden-files
matifali Jan 3, 2025
9f6adaa
fixup
matifali Jan 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix markdown lint issues in docs and Makefile
- Quote glob patterns in Makefile to handle whitespace.
- Add alt text to images for better accessibility.
- Specify language for code blocks for syntax highlighting.
  • Loading branch information
matifali committed Dec 11, 2024
commit 3b396d3331427b3855cc665e7c0d8f4f3ef7ea1c
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ lint/helm:
lint/markdown:
cd site
../scripts/pnpm_install.sh
pnpm exec markdownlint-cli2 --fix ../docs/**/*.md
pnpm exec markdownlint-cli2 --fix "../docs/**/*.md"
.PHONY: lint/markdown

# All files generated by the database should be added here, and this can be used
Expand Down
16 changes: 8 additions & 8 deletions docs/install/cloud/azure-vm.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This guide assumes you have full administrator privileges on Azure.
From the Azure Portal, navigate to the Virtual Machines Dashboard. Click Create,
and select creating a new Azure Virtual machine .

<img src="../../images/platforms/azure/azure1.jpg">
<img src="../../images/platforms/azure/azure1.jpg" alt="Azure VM creation page">

This will bring you to the `Create a virtual machine` page. Select the
subscription group of your choice, or create one if necessary.
Expand All @@ -22,26 +22,26 @@ of your choice. Change the region to something more appropriate for your current
location. For this tutorial, we will use the base selection of the Ubuntu Gen2
Image and keep the rest of the base settings for this image the same.

<img src="../../images/platforms/azure/azure2.png">
<img src="../../images/platforms/azure/azure2.png" alt="Azure VM instance details">

<img src="../../images/platforms/azure/azure3.png">
<img src="../../images/platforms/azure/azure3.png" alt="Azure VM size selection">

Up next, under `Inbound port rules` modify the Select `inbound ports` to also
take in `HTTPS` and `HTTP`.

<img src="../../images/platforms/azure/azure4.png">
<img src="../../images/platforms/azure/azure4.png" alt="Azure VM inbound port rules">

The set up for the image is complete at this stage. Click `Review and Create` -
review the information and click `Create`. A popup will appear asking you to
download the key pair for the server. Click
`Download private key and create resource` and place it into a folder of your
choice on your local system.

<img src="../../images/platforms/azure/azure5.png">
<img src="../../images/platforms/azure/azure5.png" alt="Azure VM key pair generation">

Click `Return to create a virtual machine`. Your VM will start up!

<img src="../../images/platforms/azure/azure6.png">
<img src="../../images/platforms/azure/azure6.png" alt="Azure VM deployment complete">

Click `Go to resource` in the virtual machine and copy the public IP address.
You will need it to SSH into the virtual machine via your local machine.
Expand Down Expand Up @@ -100,12 +100,12 @@ First, run `coder template init` to create your first template. You’ll be give
a list of possible templates to use. This tutorial will show you how to set up
your Coder instance to create a Linux based machine on Azure.

<img src="../../images/platforms/azure/azure9.png">
<img src="../../images/platforms/azure/azure9.png" alt="Coder CLI template init">

Press `enter` to select `Develop in Linux on Azure` template. This will return
the following:

<img src="../../images/platforms/azure/azure10.png">
<img src="../../images/platforms/azure/azure10.png" alt="Coder CLI template init">

To get started using the Azure template, install the Azure CLI by following the
instructions
Expand Down
2 changes: 1 addition & 1 deletion docs/user-guides/workspace-access/emacs-tramp.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ editing operations on a remote server.

To connect to your workspace first run:

```
```shell
coder config-ssh
```

Expand Down
4 changes: 4 additions & 0 deletions docs/user-guides/workspace-access/jetbrains.md
Original file line number Diff line number Diff line change
Expand Up @@ -378,14 +378,18 @@ Fleet can connect to a Coder workspace by following these steps.

1. [Install Fleet](https://www.jetbrains.com/fleet/download)
2. Install Coder CLI

```shell
curl -L https://coder.com/install.sh | sh
```

3. Login and configure Coder SSH.

```shell
coder login coder.example.com
coder config-ssh
```

4. Connect via SSH with the Host set to `coder.workspace-name`
![Fleet Connect to Coder](../../images/fleet/ssh-connect-to-coder.png)

Expand Down
2 changes: 1 addition & 1 deletion docs/user-guides/workspace-access/port-forwarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ protocol configuration for each shared port individually.
You can also access any port on the workspace and can configure the port
protocol manually by appending a `s` to the port in the URL.

```
```console
# Uses HTTP
https://33295--agent--workspace--user--apps.example.com/
# Uses HTTPS
Expand Down
1 change: 0 additions & 1 deletion examples/examples.gen.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Code generated by examplegen. DO NOT EDIT.
[
{
"id": "aws-devcontainer",
Expand Down
Loading
0