8000 feat: create e2e tests for organization custom roles page by jaaydenh · Pull Request #15814 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: create e2e tests for organization custom roles page #15814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 16, 2024
Merged

feat: create e2e tests for organization custom roles page #15814

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c2268e4
feat: wip
jaaydenh Dec 6, 2024
ab42630
feat: add custom roles e2e tests
jaaydenh Dec 10, 2024
1ef60fc
fix: use different org name for test
jaaydenh Dec 10, 2024
1c16357
fix: format
jaaydenh Dec 10, 2024
eae7fae
feat: add test for custom roles disabled
jaaydenh Dec 10, 2024
992c579
fix: format
jaaydenh Dec 10, 2024
6330959
fix: run test only if there is no premium license
jaaydenh Dec 10, 2024
6723ce8
fix: format
jaaydenh Dec 10, 2024
d5ca1b0
fix: use randomName
jaaydenh Dec 12, 2024
4a8a8a8
fix: format
jaaydenh Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: add custom roles e2e tests
  • Loading branch information
@jaaydenh
jaaydenh committed Dec 10, 2024
commit ab4263019d5a94f6ff196bc64cf434eebdb52c5a
152 changes: 98 additions & 54 deletions site/e2e/tests/organizations/customRoles/customRoles.spec.ts
View file
Open in desktop
8000 < 8000 td class="blob-code blob-code-context js-file-line"> await page.goto(`/organizations/${org.name}/roles`);
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import { test, expect } from "@playwright/test";
import { MockOrganization } from "testHelpers/entities";
import {
createOrganization,
createCustomRole,
getCurrentOrgId,
createOrganizationWithName,
setupApiCalls,
deleteOrganization,
} from "../../../api";
import { requiresLicense } from "../../../helpers";
import { beforeCoderTest } from "../../../hooks";
Expand All @@ -13,25 +12,81 @@ test.describe("CustomRolesPage", () => {

test.beforeEach(async ({ page }) => await beforeCoderTest(page));

test("create custom role", async ({ page }) => {
test("create custom role and cancel edit changes", async ({ page }) => {
requiresLicense();
await setupApiCalls(page);

const org = await createOrganization();
const org = await createOrganizationWithName("developers");

const customRole = await createCustomRole(org.id, "custom-role-test-1", "Custom Role Test 1");

await page.goto(`/organizations/${org.name}/roles`);
const roleRow = page.getByTestId(`role-${customRole.name}`);
await expect(roleRow.getByText(customRole.display_name)).toBeVisible();
await expect(roleRow.getByText("organization_member")).toBeVisible();

await roleRow.getByRole("button", { name: "More options" }).click()
const menu = page.locator("#more-options");
await menu.getByText("Edit").click();

await expect(page).toHaveURL(`/organizations/${org.name}/roles/${customRole.name}`);

const cancelButton = page.getByRole("button", { name: "Cancel" }).first();
await expect(cancelButton).toBeVisible();
await cancelButton.click();

await expect(page).toHaveURL(`/organizations/${org.name}/roles`);

await deleteOrganization("developers");
});

test("create custom role, edit role and save changes", async ({ page }) => {
requiresLicense();
await setupApiCalls(page);

const org = await createOrganizationWithName("developers");

const customRole = await createCustomRole(org.id, "custom-role-test-1", "Custom Role Test 1");

await page.goto(`/organizations/${org.name}/roles`);
const roleRow = page.getByTestId(`role-${customRole.name}`);
await expect(roleRow.getByText(customRole.display_name)).toBeVisible();
await expect(roleRow.getByText("organization_member")).toBeVisible();

await page.goto(`/organizations/${org.name}/roles/${customRole.name}`);

const displayNameInput = page.getByRole("textbox", { name: "Display name" });
await displayNameInput.fill("Custom Role Test 2 Edited");

const groupCheckbox = page.getByTestId("group").getByRole("checkbox");
await expect(groupCheckbox).toBeVisible();
await groupCheckbox.click();

const organizationMemberCheckbox = page.getByTestId("organization_member").getByRole("checkbox");
await expect(organizationMemberCheckbox).toBeVisible();
await organizationMemberCheckbox.click();

const saveButton = page.getByRole("button", { name: "Save" }).first();
await expect(saveButton).toBeVisible();
await saveButton.click();

await expect(roleRow.getByText("Custom Role Test 2 Edited")).toBeVisible();

const roleRow2 = page.getByTestId(`role-${customRole.name}`);
await expect(roleRow2.getByText("organization_member")).not.toBeVisible();
await expect(roleRow2.getByText("group")).toBeVisible();

await expect(page).toHaveURL(`/organizations/${org.name}/roles`);

await deleteOrganization("developers");
});

test("displays built-in role without edit/delete options", async ({ page }) => {
requiresLicense();
await setupApiCalls(page);

const org = await createOrganization();
const org = await createOrganizationWithName("developers");


const roleRow = page.getByTestId("role-organization-admin");
Expand All @@ -41,74 +96,63 @@ test.describe("CustomRolesPage", () => {

// Verify that the more menu (three dots) is not present for built-in roles
await expect(roleRow.getByRole("button", { name: "More options" })).not.toBeVisible();

await deleteOrganization("developers");
});

test("can navigate to create custom role", async ({ page }) => {
test("create custom role with UI", async ({ page }) => {
requiresLicense();
await setupApiCalls(page);

const org = await createOrganization();
const org = await createOrganizationWithName("developers");

await page.goto(`/organizations/${org.name}/roles`);

await page.getByRole("link", { name: "Create custom role" }).first().click();

await expect(page).toHaveURL(`/organizations/${org.name}/roles/create`);
});

// test("delete custom role", async ({ page }) => {
// requiresLicense();
// await setupApiCalls(page);
const customRoleName = "custom-role-test";
const roleNameInput = page.getByRole("textbox", { exact: true, name: "Name" });
await roleNameInput.fill(customRoleName);

// const org = await createOrganization();
// const customRole = await createCustomRole(org.id, "custom-role-test-1", "Custom Role Test 1");
// await page.goto(`/organizations/${org.name}/roles`);
const customRoleDisplayName = "Custom Role Test";
const displayNameInput = page.getByRole("textbox", { exact: true, name: "Display Name" });
await displayNameInput.fill(customRoleDisplayName);

// // const roleRow = page.getByTestId("role-custom-role-test-1");
// await page.getByRole("button", { name: "More options" }).click();
await page.getByRole("button", { name: "Create Role" }).first().click();

// // Check menu items
// await expect(page.getByRole("menuitem", { name: "Edit" })).toBeVisible();
// await expect(page.getByText("Edit")).toBeVisible();
// // const menu = page.getByRole("menu");
await expect(page).toHaveURL(`/organizations/${org.name}/roles`);

// const deleteButton = page.getByRole("menuitem", { name: "Delete&hellip;" });
// await expect(deleteButton).toBeVisible();
// await deleteButton.click();
const roleRow = page.getByTestId(`role-${customRoleName}`);
await expect(roleRow.getByText(customRoleDisplayName)).toBeVisible();
await expect(roleRow.getByText("None")).toBeVisible();

// const input = page.getByRole("textbox");
// await input.fill(customRole.name);
// await page.getByRole("button", { name: "Delete" }).click();
await deleteOrganization("developers");
});

// await expect(page.getByText("Custom role deleted successfully!")).toBeVisible();
// });
test("delete custom role", async ({ page }) => {
requiresLicense();
await setupApiCalls(page);

// test("shows delete confirmation dialog", async ({ page }) => {
// // Click delete option
// const roleRow = page.getByTestId("role-custom-role-test-1");
// await roleRow.getByRole("button", { name: "More options" }).click();
// await page.getByRole("menuitem", { name: "Delete…" }).click();

// // Check dialog content
// await expect(page.getByRole("dialog")).toBeVisible();
// await expect(page.getByText(/Are you sure you want to delete/)).toBeVisible();
// await expect(page.getByRole("button", { name: "Cancel" })).toBeVisible();
// await expect(page.getByRole("button", { name: "Delete" })).toBeVisible();
// });
const org = await createOrganizationWithName("developers");
const customRole = await createCustomRole(org.id, "custom-role-test-1", "Custom Role Test 1");
await page.goto(`/organizations/${org.name}/roles`);

// test("handles delete role successfully", async ({ page }) => {
// // Mock delete API call
// await page.route("**/api/v2/organizations/*/roles/*", (route) =>
// route.fulfill(createMockApiResponse({}))
// );
const roleRow = page.getByTestId(`role-${customRole.name}`);
await roleRow.getByRole("button", { name: "More options" }).click()

// // Perform delete
// const roleRow = page.getByTestId("role-custom-role-test-1");
// await roleRow.getByRole("button", { name: "More options" }).click();
// await page.getByRole("menuitem", { name: "Delete…" }).click();
// await page.getByRole("button", { name: "Delete" }).click();
const menu = page.locator("#more-options");
await menu.getByText("Delete…").click();

// // Check success message
// await expect(page.getByText("Custom role deleted successfully!")).toBeVisible();
// });
const input = page.getByRole("textbox");
await input.fill(customRole.name);
await page.getByRole("button", { name: "Delete" }).click();

await expect(page.getByText("Custom role deleted successfully!")).toBeVisible();

await deleteOrganization("developers");
});

// test("shows paywall when custom roles not enabled", async ({ page }) => {
// // Mock feature flags to disable custom roles
Expand Down
0