8000 feat(examples/templates/gcp-devcontainer): promote module usage by phorcys420 · Pull Request #15549 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat(examples/templates/gcp-devcontainer): promote module usage #15549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

feat(examples/templates/gcp-devcontainer): promote module usage #15549

merged 1 commit into from
Nov 29, 2024

Conversation

phorcys420
Copy link
Member
@phorcys420 phorcys420 commented Nov 16, 2024 •
edited
Loading

This PR switches adds the GCP region and JetBrains Gateway module.

  • Testing
    • Workspace gets provisioned and region selector works
    • code-server works as intended
    • JetBrains gateway works as intended (unable to test on the train)

@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 24, 2024
@github-actions github-actions bot closed this Nov 28, 2024
@phorcys420 phorcys420 reopened this Nov 28, 2024
@phorcys420
Copy link
Member Author
phorcys420 commented Nov 28, 2024 •
edited
Loading

Available on dogfood @ https://dev.coder.com/templates/coder/gcp-devcontainer/versions/promote-modules-pr-1461

@github-actions github-actions bot removed the stale This issue is like stale bread. label Nov 29, 2024
@phorcys420 phorcys420 marked this pull request as ready for review November 29, 2024 13:16
@phorcys420 phorcys420 requested review from matifali, mafredri and johnstcn and removed request for matifali and mafredri November 29, 2024 13:16
@phorcys420 phorcys420 enabled auto-merge (squash) November 29, 2024 13:17
matifali
matifali approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member
@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚅

@phorcys420 phorcys420 merged commit 0b4eb8b into main Nov 29, 2024
61 checks passed
@phorcys420 phorcys420 deleted the phorcys/promote-modules-gcp-devcontainer branch November 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali approved these changes

@johnstcn johnstcn Awaiting requested review from johnstcn

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@phorcys420 phorcys420

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3484
2 participants
@phorcys420 @matifali
0