8000 chore: create ResourceNotificationMessage and AsNotifier by DanielleMaywood · Pull Request #15301 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: create ResourceNotificationMessage and AsNotifier #15301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2024
Merged

chore: create ResourceNotificationMessage and AsNotifier #15301

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b96e50
chore: begin impl of AsNotifier with ResourceNotificationMessage
DanielleMaywood Oct 30, 2024
72a2e9d
fix: do todo tasks
DanielleMaywood Oct 31, 2024
68687de
fix: add delete policy
DanielleMaywood Oct 31, 2024
da84f4b
fix: roles_test
DanielleMaywood Oct 31, 2024
c12407a
fix: update inaccurate comment
DanielleMaywood Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: roles_test
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Oct 31, 2024
commit da84f4ba909dc074a34eac2cd4aab84d27b2b483
2 changes: 1 addition & 1 deletion coderd/rbac/roles_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ func TestRolePermissions(t *testing.T) {
},
{
Name: "NotificationMessages",
Actions: []policy.Action{policy.ActionCreate, policy.ActionRead, policy.ActionUpdate},
Actions: []policy.Action{policy.ActionCreate, policy.ActionRead, policy.ActionUpdate, policy.ActionDelete},
Resource: rbac.ResourceNotificationMessage,
AuthorizeMap: map[bool][]hasAuthSubjects{
true: {owner},
Expand Down
Loading
0