8000 chore(enterprise/coderd/license): fix time-related flake in license expiration warning test by johnstcn · Pull Request #15228 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore(enterprise/coderd/license): fix time-related flake in license expiration warning test #15228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

chore(enterprise/coderd/license): fix time-related flake in license expiration warning test #15228

merged 1 commit into from
Oct 25, 2024

Conversation

johnstcn
Copy link
Member

Fixes the following time-related test flake:

--- FAIL: TestEntitlements (0.00s)
    --- FAIL: TestEntitlements/Expiration_warning (0.00s)
        license_test.go:140: 
                Error Trace:    /home/coder/src/coder/coder/enterprise/coderd/license/license_test.go:140
                Error:          []string{"Your license expires in 3 days.", "Browser Only is enabled but your license is not entitled to this feature.", "SCIM is enabled but your license is not entitled to this feature.", "Template RBAC is enabled but your license is not entitled to this feature.", "External Provisioner Daemons is enabled but your license is not entitled to this feature.", "Appearance is enabled but your license is not entitled to this feature.", "Advanced Template Scheduling is enabled but your license is not entitled to this feature.", "Workspace Proxy is enabled but your license is not entitled to this feature.", "User Role Management is enabled but your license is not entitled to this feature.", "External Token Encryption is enabled but your license is not entitled to this feature.", "Workspace Batch Actions is enabled but your license is not entitled to this feature.", "Access Control is enabled but your license is not entitled to this feature.", "Control Shared Ports is enabled but your license is not entitled to this feature.", "Custom Roles is enabled but your license is not entitled to this feature.", "Multiple Organizations is enabled but your license is not entitled to this feature."} does not contain "Your license expires in 2 days."
                Test:           TestEntitlements/Expiration_warning
FAIL
FAIL    github.com/coder/coder/v2/enterprise/coderd/license     0.039s
FAIL

@johnstcn johnstcn self-assigned this Oct 25, 2024
@johnstcn johnstcn merged commit 5bcaa93 into main Oct 25, 2024
27 checks passed
@johnstcn johnstcn deleted the cj/flake/license-expiration-warning branch October 25, 2024 11:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mafredri
0