8000 bug: Don't try to handle SIGINT when prompting for passwords by dwahler · Pull Request #1498 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

bug: Don't try to handle SIGINT when prompting for passwords #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 18, 2022
Merged

bug: Don't try to handle SIGINT when prompting for passwords #1498

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
78066d4
add failing unit test for terminal echo state when reading password
dwahler May 16, 2022
a3dee26
fixup! add explanatory comment
dwahler May 16, 2022
6b78f45
don't try to handle SIGINT in cliui.Prompt
dwahler May 16, 2022
8d3ee6a
Skip signal handler for passwords, but keep it for other prompts
dwahler May 16, 2022
57a198f
fix lint errors
dwahler May 17, 2022
1dd8ccf
only run password prompt test on Linux
dwahler May 17, 2022
fa51354
get rid of pty.PTYFile() accessor that isn't implementable on Windows
dwahler May 17, 2022
cc81c7e
bump password prompt test delay to 100ms
dwahler May 17, 2022
687194f
make TestPasswordTerminalState cross-platform
dwahler May 17, 2022
dfa133c
hopefully fix Windows build
dwahler May 17, 2022
f2dce8b
try again to fix Windows build
dwahler May 17, 2022
4ee7ffd
remove support for EchoEnabled() on Windows
dwahler May 17, 2022
c59b6ef
fixup! remove errant comment
dwahler May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
try again to fix Windows build
  • Loading branch information
@dwahler
dwahler committed May 17, 2022
commit f2dce8b896f0d81af2bde3d31864266d6a7dedb1
< 7D99 /div> 2 changes: 1 addition & 1 deletion pty/pty_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func (p *ptyWindows) Close() error {

func (p *ptyWindows) EchoEnabled() (bool, error) {
var state uint32
err := windows.GetConsoleMode(p.console, &state)
err := windows.GetConsoleMode(windows.Handle(p.inputRead.Fd()), &state)
if err != nil {
return false, err
}
Expand Down
0