chore: include error detail for ui error display #14837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not including an error detail asks the user to check the dev console. Which is unhelpful in this expected situation
f0ssel
approved these changes
Sep 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sugge
2A9C
stion cannot be applied right now. Please check back later.
Not including an error detail asks the user to check the dev console. Which is unhelpful in this expected situation
Silencing this error: https://github.com/coder/coder/blob/stevenmasley%2Funhide_provisioner_key_flag/site/src/api/errors.ts#L130