8000 feat: add warning dialog when removing member from organization by jaaydenh · Pull Request #14695 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: add warning dialog when removing member from organization #14695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 27, 2024
Merged

feat: add warning dialog when removing member from organization #14695

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b2cd09
feat: add warning dialog when removing member from organization
jaaydenh Sep 16, 2024
cb6d1a6
chore: update copy
jaaydenh Sep 27, 2024
591bf5e
fix: fix test
jaaydenh Sep 27, 2024
396d987
chore: update copy
jaaydenh Sep 27, 2024
4e7b763
fix: review comments
jaaydenh Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix test
  • Loading branch information
@jaaydenh
jaaydenh committed Sep 27, 2024
commit 591bf5eeceb9a0e2790d3c4a6ea27a9f99453d3f
5 changes: 4 additions & 1 deletion site/src/pages/ManagementSettingsPage/OrganizationMembersPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ const removeMember = async () => {

const removeButton = screen.getByText(/Remove/);
await user.click(removeButton);

const dialog = await within(document.body).findByRole("dialog");
await user.click(within(dialog).getByRole("button", { name: "Remove" }));
};

const updateUserRole = async (role: SlimRole) => {
Expand Down Expand Up @@ -83,7 +86,7 @@ describe("OrganizationMembersPage", () => {
it("shows a success message", async () => {
await renderPage();
await removeMember();
await screen.findByText("Member removed successfully.");
await screen.findByText("User removed from organization successfully!");
});
});
});
Expand Down
0