-
Notifications
You must be signed in to change notification settings - Fork 929
feat: create UI badges for labeling beta features #14661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
f843f23
chore: finish draft work for FeatureBadge component
Parkreiner 43874a4
fix: add visually-hidden helper text for screen readers
Parkreiner fb70781
chore: add stories for highlighted state
Parkreiner c2470f9
fix: update base styles
Parkreiner 693946f
chore: remove debug display option
Parkreiner c2d7cda
Merge branch 'main' into mes/beta-badges
Parkreiner 129613b
chore: update Popover to propagate events
Parkreiner 6adea6b
wip: commit progress on FeatureBadge update
Parkreiner d4455a8
wip: commit more progress
Parkreiner 8ae71d3
chore: update tag definitions to satify Biome
Parkreiner 0ad68af
chore: update all colors for preview role
Parkreiner 781a609
fix: make sure badge shows as hovered while inside tooltip
Parkreiner a981864
wip: commit progress on adding story for controlled variant
Parkreiner f47d059
fix: sort imports
Parkreiner ad61763
refactor: change component API to be more obvious/ergonomic
Parkreiner 6e16aaa
fix: add biome-ignore comments to more base files
Parkreiner 6a19b61
fix: update import order again
Parkreiner a233867
chore: revert biome-ignore comment
Parkreiner 8cbe639
Merge branch 'main' into mes/beta-badges
Parkreiner 7e1ec68
chore: update body text for tooltip
Parkreiner 1b58e4d
chore: update dark preivew role to use sky palette
Parkreiner ebc5397
chore: update color palettes for light/darkBlue themes
Parkreiner a9b6897
chore: add beta badge to organizations subheader
Parkreiner 31e1fa7
chore: add beta badge to organizations settings page
Parkreiner e16b140
chore: beef up font weight for form header
Parkreiner 3aeb3c0
fix: update text contrast for org menu list
Parkreiner 71323ac
chore: add beta badge to deployment dropdown
Parkreiner da31c84
fix: run biome on imports
Parkreiner c7308c3
chore: remove API for controlling FeatureBadge hover styling externally
Parkreiner 230aa1d
chore: add xs size for badge
Parkreiner fb4b734
fix: update font weight for xs feature badges
Parkreiner 5a7bbd3
chore: add beta badges to all org headers
Parkreiner 9521f25
Merge branch 'main' into mes/beta-badges
Parkreiner 6638942
fix: turn badges and tooltips into separate concerns
Parkreiner 9a18e51
fix: update hover styling
Parkreiner b093a99
docs: update wording on comment
Parkreiner 9647fc6
fix: apply formatting
Parkreiner 0197466
chore: rename FeatureBadge to FeatureStageBadge
Parkreiner fb86964
refactor: redefine FeatureStageBadge
Parkreiner 0f64533
chore: update stories
Parkreiner 6a2cfcf
fix: add blur behavior to popover
Parkreiner eb2b1c2
chore: revert theme colors
Parkreiner 0b46eca
chore: create featureStage branding namespace
Parkreiner 4302b3d
fix: make sure cleanup function is set up properly
Parkreiner be8121e
docs: update wording on comment for clarity
Parkreiner 1e5d62b
Merge branch 'main' into mes/beta-badges
Parkreiner a824404
Merge branch 'main' into mes/beta-badges
Parkreiner 39daf80
refactor: move styles down
Parkreiner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: rename FeatureBadge to FeatureStageBadge
- Loading branch information
commit 01974669ed2c4aa00e815a1c891c00931da26b3c
There are no files selected for viewing
10 changes: 5 additions & 5 deletions
10
...nts/FeatureBadge/FeatureBadge.stories.tsx → ...eStageBadge/FeatureStageBadge.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ import type { | |
} from "api/typesGenerated"; | ||
import { ErrorAlert } from "components/Alert/ErrorAlert"; | ||
import { DeleteDialog } from "components/Dialogs/DeleteDialog/DeleteDialog"; | ||
import { FeatureBadge } from "components/FeatureBadge/FeatureBadge"; | ||
import { FeatureStageBadge } from "components/FeatureStageBadge/FeatureStageBadge"; | ||
import { | ||
FormFields, | ||
FormFooter, | ||
|
@@ -69,7 +69,9 @@ export const OrganizationSettingsPageView: FC< | |
<div> | ||
<SettingsHeader | ||
title="Settings" | ||
badges={<FeatureBadge type="beta" variant="interactive" size="lg" />} | ||
badges={ | ||
<FeatureStageBadge type="beta" variant="interactive" size="lg" /> | ||
} | ||
/> | ||
|
||
{Boolean(error) && !isApiValidationError(error) && ( | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.