8000 fix(site): prevent 404s by removing version postfix from URLs by SomewhatJustin · Pull Request #14601 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

fix(site): prevent 404s by removing version postfix from URLs #14601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

SomewhatJustin
Copy link
Contributor
@SomewhatJustin SomewhatJustin commented Sep 9, 2024

I found broken links to the docs when looking at one of my locally running workspaces on the site.

Example broken link: https://coder.com/docs/@v2.15.0+190cd1c/install
I found I could fix the link by removing the postfix info. This is normally done automatically, but the existing code was only stripping out anything in the version number after a -. Now it checks for either a - or +.

Attached video for clarity.

CleanShot.2024-09-08.at.21.05.26.mp4

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Sep 9, 2024
Copy link
github-actions bot commented Sep 9, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@SomewhatJustin
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull request Sep 9, 2024
@SomewhatJustin SomewhatJustin changed the title fixed version postfix url removal fix: 404s from version postfix url removal Sep 9, 2024
@SomewhatJustin SomewhatJustin changed the title fix: 404s from version postfix url removal fix(site): prevent 404s by removing version postfix from URLs Sep 9, 2024
@aslilac aslilac merged commit 85cc695 into coder:main Sep 10, 2024
41 of 43 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
@bcpeinhardt
Copy link
Contributor

Thank you!

@aslilac
Copy link
Member
aslilac commented Sep 10, 2024

thanks for the fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Pull Requests and issues created by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0