8000 feat: Redesign workspaces page by kylecarbs · Pull Request #1450 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content

feat: Redesign workspaces page #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 16, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix e2e test
  • Loading branch information
kylecarbs committed May 16, 2022
commit 82641abf4b425ed210db97ab9d1b5cb3bc7ca20b
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { Page } from "@playwright/test"
import { BasePom } from "./BasePom"

export class TemplatesPage extends BasePom {
export class WorkspacesPage extends BasePom {
constructor(baseURL: string | undefined, page: Page) {
super(baseURL, "/templates", page)
super(baseURL, "/workspaces", page)
}
}
2 changes: 1 addition & 1 deletion site/e2e/pom/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export * from "./SignInPage"
export * from "./TemplatesPage"
export * from "./WorkspacesPage"
10 changes: 5 additions & 5 deletions site/e2e/tests/login.spec.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import { test } from "@playwright/test"
import { email, password } from "../constants"
import { SignInPage, TemplatesPage } from "../pom"
import { SignInPage, WorkspacesPage } from "../pom"
import { waitForClientSideNavigation } from "./../util"

test("Login takes user to /templates", async ({ baseURL, page }) => {
test("Login takes user to /workspaces", async ({ baseURL, page }) => {
await page.goto(baseURL + "/", { waitUntil: "networkidle" })

// Log-in with the default credentials we set up in the development server
const signInPage = new SignInPage(baseURL, page)
await signInPage.submitBuiltInAuthentication(email, password)

const templatesPage = new TemplatesPage(baseURL, page)
await waitForClientSideNavigation(page, { to: templatesPage.url })
const workspacesPage = new WorkspacesPage(baseURL, page)
await waitForClientSideNavigation(page, { to: workspacesPage.url })

await page.waitForSelector("text=Templates")
await page.waitForSelector("text=Workspaces")
})
0