8000 fix: delete workspace agent stats after 180 days by ethanndickson · Pull Request #14489 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: delete workspace agent stats after 180 days #14489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: delete workspace agent stats after 180 days #14489

merged 1 commit into from
Aug 30, 2024

Conversation

ethanndickson
Copy link
Member
@ethanndickson ethanndickson commented Aug 30, 2024 •
edited
Loading

Fixes #13430.

The test for purging old workspace agent stats from the DB was consistently failing when ran with Postgres towards the end of the month, but not with the in-memory DB.

This was because month intervals are calculated differently for time.Time and the interval type in Postgres:

ethan=# SELECT
    '2024-08-30'::DATE AS original_date,
    ('2024-08-30'::DATE - INTERVAL '6 months') AS sub_date;
 original_date |      sub_date
---------------+---------------------
 2024-08-30    | 2024-02-29 00:00:00
(1 row)

Using func (t Time) AddDate(years int, months int, days int) Time, where months is -6:

Original: 2024-08-30 00:00:00 +0000 UTC
6 Months Earlier: 2024-03-01 00:00:00 +0000 UTC

Since 6 months was chosen arbitrarily, we should be able to change it to 180 days, to remove any ambiguity between the in-memory DB, and the Postgres DB. The alternative solution would involve implementing Postgres' month interval algorithm in Go.

The UI only shows stats as old as 168 days (24 weeks), so a frontend change isn't required for the extra days of stats we lose in some cases.

@ethanndickson Graphite App
Copy link
Member Author
ethanndickson commented Aug 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson requested a review from sreya August 30, 2024 05:28
@ethanndickson ethanndickson marked this pull request as ready for review August 30, 2024 05:28
@ethanndickson ethanndickson mentioned this pull request Aug 30, 2024
Merged
@ethanndickson ethanndickson requested a review from mafredri August 30, 2024 05:34
@ethanndickson ethanndickson mentioned this 8000 pull request Aug 30, 2024
Merged
@ethanndickson
Copy link
Member Author

I realise now we could just skip the test with the in-memory DB... Happy to do either...

dannykopping
dannykopping approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor
@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanndickson ethanndickson merged commit 6287502 into main Aug 30, 2024
59 checks passed
@ethanndickson ethanndickson deleted the 08-30-fix_delete_workspace_agent_stats_after_180_days branch August 30, 2024 08:30
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@mafredri
Copy link
Member
8E61

Nice find! I agree with the fix, predictability (180) is nicer than ambiguity (varying) 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@sreya sreya Awaiting requested review from sreya

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test flake: TestDeleteOldWorkspaceAgentStats
3 participants
@ethanndickson @mafredri @dannykopping
0