8000 chore: redirect to the correct template page routes by aslilac · Pull Request #14230 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: redirect to the correct template page routes #14230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 12, 2024
Merged

chore: redirect to the correct template page routes #14230

merged 9 commits into from
Aug 12, 2024

Conversation

aslilac
Copy link
Member
@aslilac aslilac commented Aug 9, 2024 •
edited
Loading

Closes #14068

  • /templates/org/template on a single-org deployment should remove the "/org" from the path
  • likewise, /templates/template on a multi-org deployment should redirect to /templates/the-default-org-name/template

preserves the subpage as well, albeit in a way I don't like. couldn't come up with anything better, but I have to admit it feels very hacky.

@aslilac aslilac changed the base branch from main to show-org-name-on-templates-page August 9, 2024 20:10
@aslilac aslilac changed the title Templates redirect @aslilac chore: enforce correct template page routes Aug 9, 2024
@aslilac aslilac changed the title @aslilac chore: enforce correct template page routes chore: enforce correct template page routes Aug 9, 2024
@alwaysmeticulous alwaysmeticulous
Copy link
alwaysmeticulous bot commented Aug 9, 2024 •
edited
Loading

🤖 Meticulous spotted visual differences in 213 of 1313 screens tested: view and approve differences detected.

Last updated for commit ff0101b. This comment will update as new commits are pushed.

@aslilac aslilac changed the title chore: enforce correct template page routes chore: redirect to the correct template page routes Aug 9, 2024
Base automatically changed from show-org-name-on-templates-page to main August 12, 2024 15:15
BrunoQuaresma
BrunoQuaresma approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator
@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok but since there are a few conditionals inside of the component I would create a test for each one.

@aslilac aslilac merged commit 4c7132f into main Aug 12, 2024
29 checks passed
@aslilac aslilac deleted the templates-redirect branch August 12, 2024 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@jaaydenh jaaydenh Awaiting requested review from jaaydenh

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
Organizations & Custom Roles (GA)
Development

Successfully merging this pull request may close these issues.

cleanup frontend template routing
3 participants
@aslilac @BrunoQuaresma @Kira-Pilot
0