8000 fix: don't require `organization_id` in body when updating a custom role by aslilac · Pull Request #14102 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: don't require organization_id in body when updating a custom role #14102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2024
Merged

fix: don't require organization_id in body when updating a custom role #14102

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d818498
fix: don't require `organization_id` in body when updating a custom role
aslilac Aug 1, 2024
de5be5f
fix comments
aslilac Aug 1, 2024
9ecefae
gen
aslilac Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comments
  • Loading branch information
@aslilac
aslilac committed Aug 1, 2024
commit de5be5fe5538051f0756a32bbc0656d6301362d4
4 changes: 2 additions & 2 deletions codersdk/roles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type Permission struct {
Action RBACAction `json:"action"`
}

// Role is a longer form of SlimRole used to edit custom roles.
// Role is a longer form of SlimRole that includes permissions details.
type Role struct {
Name string `json:"name" table:"name,default_sort" validate:"username"`
OrganizationID string `json:"organization_id,omitempty" table:"organization_id" format:"uuid"`
Expand All @@ -61,7 +61,7 @@ type Role struct {
UserPermissions []Permission `json:"user_permissions" table:"user_permissions"`
}

// Role is a longer form of SlimRole used to edit custom roles.
// PatchRoleRequest is used to edit custom roles.
type PatchRoleRequest struct {
Name string `json:"name" table:"name,default_sort" validate:"username"`
DisplayName string `json:"display_name" table:"display_name"`
Expand Down
Loading
0