8000 fix: resolve text overflow issues for workspace empty state by Parkreiner · Pull Request #14015 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: resolve text overflow issues for workspace empty state #14015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix: resolve text overflow issues for workspace empty state #14015

merged 1 commit into from
Jul 25, 2024

Conversation

Parkreiner
Copy link
Member
@Parkreiner Parkreiner commented Jul 25, 2024 •
edited
Loading

Addresses the main customer issue for #14007

Changes made

  • Updated CSS for the template CTA links that appear when there are no workspaces in the /workspaces view.
    • Whenever one of the values in either the title or description is too long and has no breakpoints that would be easy to detect by the browser, we just force the breakpoints in, so that the content doesn't overflow outside their containers.

Screenshots

Before:
Screenshot 2024-07-25 at 2 16 16 PM

After:
Screenshot 2024-07-25 at 2 14 53 PM

@Parkreiner Parkreiner self-assigned this Jul 25, 2024
cdr-bot[bot]
cdr-bot bot approved these changes Jul 25, 2024
View reviewed changes
Copy link
@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner enabled auto-merge (squash) July 25, 2024 18:18
@Parkreiner Parkreiner merged commit 9f3c1c7 into main Jul 25, 2024
37 checks passed
@Parkreiner Parkreiner deleted the mes/short-short-man branch July 25, 2024 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@Parkreiner Parkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Parkreiner
0