8000 fix: notifications: use username in workspace URLs by mtojek · Pull Request #14011 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: notifications: use username in workspace URLs #14011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2024
Merged

fix: notifications: use username in workspace URLs #14011

merged 4 commits into from
Jul 25, 2024

Conversation

mtojek
Copy link
Member
@mtojek mtojek commented Jul 25, 2024 •
edited
Loading

Fixes: #13998

This PR adjusts notification templates to use correct username handle in notification actions.

@mtojek mtojek self-assigned this Jul 25, 2024
dannykopping
dannykopping reviewed Jul 25, 2024
View reviewed changes
dannykopping
dannykopping approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor
@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtojek mtojek marked this pull request as ready for review July 25, 2024 09:59
dannykopping
dannykopping approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor
@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtojek mtojek merged commit d488853 into main Jul 25, 2024
35 checks passed
@mtojek mtojek deleted the 13998-username branch July 25, 2024 10:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: broken workspace URL in notifications
2 participants
@mtojek @dannykopping
0