8000 fix: use static port number for prometheus test by mtojek · Pull Request #14000 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: use static port number for prometheus test #14000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2024
Merged

fix: use static port number for prometheus test #14000

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b434dce
fix: use static port number for prometheus test
mtojek Jul 24, 2024
3e9ec62
rephrase comment
mtojek Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
rephrase comment
  • Loading branch information
@mtojek
mtojek committed Jul 24, 2024
commit 3e9ec62b6c5018aa4a284217edf99384f1f90e6e
6 changes: 4 additions & 2 deletions enterprise/cli/provisionerdaemons_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,11 @@ func TestProvisionerDaemon_SessionToken(t *testing.T) {
})
}

//nolint:paralleltest,tparallel // Prometheus endpoint tends to fail with `bind: address already in use`.
//nolint:paralleltest,tparallel // Test uses a static port.
func TestProvisionerDaemon_PrometheusEnabled(t *testing.T) {
prometheusPort := 32001 // workaround: use static port out the ephemeral port range to present `bind: address already in use`
// Ephemeral ports have a tendency to conflict and fail with `bind: address already in use` error.
// This workaround forces a static port for Prometheus that hopefully won't be used by other tests.
prometheusPort := 32001

// Configure CLI client
client, admin := coderdenttest.New(t, &coderdenttest.Options{
Expand Down
Loading
0