8000 chore: improve notifications tests by dannykopping · Pull Request #13863 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: improve notifications tests #13863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 10, 2024
Merged

chore: improve notifications tests #13863

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
022d96b
Clean up tests; only use Postgres when necessary
dannykopping Jul 10, 2024
f075341
Appease the linter
dannykopping Jul 10, 2024
f34431b
Correct dbauthz test
dannykopping Jul 10, 2024
56ae992
Linter...
dannykopping Jul 10, 2024
ac85d98
Review comments
dannykopping Jul 10, 2024
edc4e7a
Make TestBasicNotificationRoundtrip use postgres and expand scope to …
dannykopping Jul 10, 2024
d47e5f0
make fmt
dannykopping Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correct dbauthz test 
Signed-off-by: Danny Kopping <danny@coder.com>
  • Loading branch information
@dannykopping
dannykopping committed Jul 10, 2024
commit f34431b48682697c3f09082f73d1a8805743db5b
3 changes: 2 additions & 1 deletion coderd/database/dbauthz/dbauthz_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2493,7 +2493,8 @@ func (s *MethodTestSuite) TestSystemFunctions() {
}))
s.Run("FetchNewMessageMetadata", s.Subtest(func(db database.Store, check *expects) {
// TODO: update this test once we have a specific role for notifications
check.Args(database.FetchNewMessageMetadataParams{}).Asserts(rbac.ResourceSystem, policy.ActionRead)
u := dbgen.User(s.T(), db, database.User{})
check.Args(database.FetchNewMessageMetadataParams{UserID: u.ID}).Asserts(rbac.ResourceSystem, policy.ActionRead)
}))
s.Run("GetNotificationMessagesByStatus", s.Subtest(func(db database.Store, check *expects) {
// TODO: update this test once we have a specific role for notifications
Expand Down
2 changes: 1 addition & 1 deletion coderd/database/dbmem/dbmem.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1864,13 +1864,13 @@
return nil
}

func (q *FakeQuerier) FetchNewMessageMetadata(ctx context.Context, arg database.FetchNewMessageMetadataParams) (database.FetchNewMessageMetadataRow, error) {

Check failure on line 1867 in coderd/database/dbmem/dbmem.go

View workflow job for this annotation

GitHub Actions / lint 

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
err := validateDatabaseType(arg)
if err != nil {
return database.FetchNewMessageMetadataRow{}, err
}

user, err := q.GetUserByID(ctx, arg.UserID)
user, err := q.getUserByIDNoLock(arg.UserID)
if err != nil {
return database.FetchNewMessageMetadataRow{}, xerrors.Errorf("fetch user: %w", err)
}
Expand Down
Loading
0