10000 fix: execute `rbacgen` even if dependencies' mod times are older than source file's by dannykopping · Pull Request #13757 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: execute rbacgen even if dependencies' mod times are older than source file's #13757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix: execute rbacgen even if dependencies' mod times are older than source file's #13757

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e343023
Execute rbacgen even if dependencies' mod times are older than source…
dannykopping Jul 2, 2024
2b623df
Review comments
dannykopping Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Review comments 
Signed-off-by: Danny Kopping <danny@coder.com>
  • Loading branch information
@dannykopping
dannykopping committed Jul 2, 2024
commit 2b623df676a69035c786a732f0e71789cd32e9fb
7 changes: 3 additions & 4 deletions Makefile
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing codersdk/rbacresources_gen.go in gen/mark-fresh for a reason?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could just be an omission?

Copy link
Member
@Emyrk Emyrk Jul 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an omission. There is no reason. We should add it

Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,7 @@ gen/mark-fresh:
$(DB_GEN_FILES) \
site/src/api/typesGenerated.ts \
coderd/rbac/object_gen.go \
codersdk/rbacresources_gen.go \
docs/admin/prometheus.md \
docs/cli.md \
docs/admin/audit-logs.md \
Expand Down Expand Up @@ -616,12 +617,10 @@ site/src/theme/icons.json: $(wildcard scripts/gensite/*) $(wildcard site/static/
examples/examples.gen.json: scripts/examplegen/main.go examples/examples.go $(shell find ./examples/templates)
go run ./scripts/examplegen/main.go > examples/examples.gen.json

.PHONY: coderd/rbac/object_gen.go # force rebuilds if any dependencies' mtimes are less than the output file
coderd/rbac/object_gen.go: scripts/rbacgen/rbacobject.gotmpl scripts/rbacgen/main.go coderd/rbac/object.go
coderd/rbac/object_gen.go: scripts/rbacgen/rbacobject.gotmpl scripts/rbacgen/main.go coderd/rbac/object.go coderd/rbac/policy/policy.go
go run scripts/rbacgen/main.go rbac > coderd/rbac/object_gen.go

.PHONY: codersdk/rbacresources_gen.go # force rebuilds if any dependencies' mtimes are less than the output file
codersdk/rbacresources_gen.go: scripts/rbacgen/codersdk.gotmpl scripts/rbacgen/main.go coderd/rbac/object.go
codersdk/rbacresources_gen.go: scripts/rbacgen/codersdk.gotmpl scripts/rbacgen/main.go coderd/rbac/object.go coderd/rbac/policy/policy.go
go run scripts/rbacgen/main.go codersdk > codersdk/rbacresources_gen.go

docs/admin/prometheus.md: scripts/metricsdocgen/main.go scripts/metricsdocgen/metrics
Expand Down
Loading
0