8000 fix: ensure single http response on organization 404 error by Emyrk · Pull Request #13629 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content
8000

fix: ensure single http response on organization 404 error #13629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: ensure single http response on organization 404 error #13629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: organization 404 write 1 http status
  • Loading branch information
@Emyrk
Emyrk committed Jun 21, 2024
commit 2d46d8ced4ea8f58bd1471595e024ad22562ade0
4 changes: 0 additions & 4 deletions coderd/httpmw/organizationparam.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ func ExtractOrganizationParam(db database.Store) func(http.Handler) http.Handler
6077 }
if httpapi.Is404Error(dbErr) {
httpapi.ResourceNotFound(rw)
httpapi.Write(ctx, rw, http.StatusNotFound, codersdk.Response{
Message: fmt.Sprintf("Organization %q not found.", arg),
Detail: "Provide either the organization id or name.",
})
return
}
if dbErr != nil {
Expand Down
Loading
0